Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(703)

#1521950: shlex.split() does not tokenize like the shell

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 9 months ago by robodan
Modified:
1 year, 2 months ago
Reviewers:
merwok, vinay_sajip, rdmurray, ghost.adh
CC:
Vinay Sajip, eric.smith, robodan_users.sourceforge.net, ezio.melotti, eric.araujo, r.david.murray, cvrebert, devnull_psf.upfronthosting.co.za, kislyuk_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 7

Patch Set 2 #

Total comments: 30

Patch Set 3 #

Total comments: 21

Patch Set 4 #

Patch Set 5 #

Total comments: 14

Patch Set 6 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/shlex.rst View 1 2 3 4 5 6 chunks +96 lines, -6 lines 2 comments Download
Lib/shlex.py View 1 2 3 4 5 9 chunks +53 lines, -21 lines 0 comments Download
Lib/test/test_shlex.py View 1 2 3 4 5 1 chunk +112 lines, -0 lines 0 comments Download

Messages

Total messages: 15
eric.araujo
Great patch. http://bugs.python.org/review/1521950/diff/3939/13004 File Lib/shlex.py (right): http://bugs.python.org/review/1521950/diff/3939/13004#newcode52 Lib/shlex.py:52: if not control: I wonder if this ...
5 years, 9 months ago #1
Vinay Sajip
BTW, I never got an email from the review tool from your comments! Just happened ...
5 years, 8 months ago #2
Vinay Sajip
http://bugs.python.org/review/1521950/diff/3939/13004 File Lib/shlex.py (right): http://bugs.python.org/review/1521950/diff/3939/13004#newcode52 Lib/shlex.py:52: if not control: On 2012/01/07 15:54:26, eric.araujo wrote: > ...
5 years, 8 months ago #3
eric.araujo
http://bugs.python.org/review/1521950/diff/3939/13005 File Lib/test/test_shlex.py (right): http://bugs.python.org/review/1521950/diff/3939/13005#newcode186 Lib/test/test_shlex.py:186: ref = ['echo', 'hi', delimiter, 'echo', 'bye'] > They ...
5 years, 8 months ago #4
r.david.murray
I've only really reviewed the docs (and thus the API) and have some concerns. I'd ...
5 years, 6 months ago #5
Vinay Sajip
My response to R. David Murray's comments. http://bugs.python.org/review/1521950/diff/4234/14802 File Doc/library/shlex.rst (right): http://bugs.python.org/review/1521950/diff/4234/14802#newcode73 Doc/library/shlex.rst:73: .. class:: ...
5 years, 6 months ago #6
r.david.murray
After you address the doc issues with a new patch and some decision is made ...
5 years, 6 months ago #7
Vinay Sajip
http://bugs.python.org/review/1521950/diff/4234/14802 File Doc/library/shlex.rst (right): http://bugs.python.org/review/1521950/diff/4234/14802#newcode73 Doc/library/shlex.rst:73: .. class:: shlex(instream=None, infile=None, posix=False, punctuation_chars=False) On 2012/04/23 11:42:09, ...
5 years, 5 months ago #8
Vinay Sajip
http://bugs.python.org/review/1521950/diff/4748/16844 File Doc/library/shlex.rst (right): http://bugs.python.org/review/1521950/diff/4748/16844#newcode87 Doc/library/shlex.rst:87: even closer behaviour to how reall shells parse, the ...
5 years, 5 months ago #9
r.david.murray
I haven't wrapped my head around the shlex parsing algorithm, so I haven't really evaluated ...
5 years, 4 months ago #10
Vinay Sajip
New patch set with these changes is now available :-) http://bugs.python.org/review/1521950/diff/4748/Doc/library/shlex.rst File Doc/library/shlex.rst (right): http://bugs.python.org/review/1521950/diff/4748/Doc/library/shlex.rst#newcode84 ...
5 years, 4 months ago #11
SilentGhost
https://bugs.python.org/review/1521950/diff/12966/Doc/library/shlex.rst File Doc/library/shlex.rst (right): https://bugs.python.org/review/1521950/diff/12966/Doc/library/shlex.rst#newcode89 Doc/library/shlex.rst:89: parsing rules. The *punctuation_chars* argument provides a way to ...
1 year, 3 months ago #12
Vinay Sajip
Thanks for the review. https://bugs.python.org/review/1521950/diff/12966/Doc/library/shlex.rst File Doc/library/shlex.rst (right): https://bugs.python.org/review/1521950/diff/12966/Doc/library/shlex.rst#newcode89 Doc/library/shlex.rst:89: parsing rules. The *punctuation_chars* argument ...
1 year, 2 months ago #13
SilentGhost
https://bugs.python.org/review/1521950/diff/17935/Doc/library/shlex.rst File Doc/library/shlex.rst (right): https://bugs.python.org/review/1521950/diff/17935/Doc/library/shlex.rst#newcode246 Doc/library/shlex.rst:246: only in whitespaces. When using :attr:`punctuation_chars`, which is Did ...
1 year, 2 months ago #14
Vinay Sajip
1 year, 2 months ago #15
https://bugs.python.org/review/1521950/diff/17935/Doc/library/shlex.rst
File Doc/library/shlex.rst (right):

https://bugs.python.org/review/1521950/diff/17935/Doc/library/shlex.rst#newco...
Doc/library/shlex.rst:246: only in whitespaces.  When using
:attr:`punctuation_chars`, which is
On 2016/07/22 14:22:35, SilentGhost wrote:
> Did you mean "on whitespaces"?

Done, but I haven't updated the patch just for this.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7