Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(75123)

#15027: Faster UTF-32 encoding

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by storchaka+cpython
Modified:
5 years, 4 months ago
Reviewers:
greg
CC:
gregory.p.smith, AntoinePitrou, haypo, larry, ezio.melotti, Arfrever, asvetlov, Charles-Fran├žois Natali, BreamoreBoy, devnull_psf.upfronthosting.co.za, storchaka, kmike84_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Objects/stringlib/codecs.h View 1 2 1 chunk +87 lines, -0 lines 3 comments Download
Objects/unicodeobject.c View 1 2 8 chunks +45 lines, -65 lines 0 comments Download

Messages

Total messages: 3
gregory.p.smith
http://bugs.python.org/review/15027/diff/10292/Objects/stringlib/codecs.h File Objects/stringlib/codecs.h (right): http://bugs.python.org/review/15027/diff/10292/Objects/stringlib/codecs.h#newcode773 Objects/stringlib/codecs.h:773: Py_UCS4 ch1, ch2, ch3, ch4; i think you want ...
5 years, 4 months ago #1
storchaka_gmail.com
http://bugs.python.org/review/15027/diff/10292/Objects/stringlib/codecs.h File Objects/stringlib/codecs.h (right): http://bugs.python.org/review/15027/diff/10292/Objects/stringlib/codecs.h#newcode773 Objects/stringlib/codecs.h:773: Py_UCS4 ch1, ch2, ch3, ch4; On 2013/12/12 00:04:23, gregory.p.smith ...
5 years, 4 months ago #2
gregory.p.smith
5 years, 4 months ago #3
http://bugs.python.org/review/15027/diff/10292/Objects/stringlib/codecs.h
File Objects/stringlib/codecs.h (right):

http://bugs.python.org/review/15027/diff/10292/Objects/stringlib/codecs.h#new...
Objects/stringlib/codecs.h:773: Py_UCS4 ch1, ch2, ch3, ch4;
On 2013/12/12 00:21:20, storchaka wrote:
> On 2013/12/12 00:04:23, gregory.p.smith wrote:
> > i think you want this line above the #if as these are only used (as
> temporaries
> > for SWAB4) outside of the conditional code.
> 
> They are not used when STRINGLIB_SIZEOF_CHAR == 1 and compiler produces
> warnings.

Oh I see. Because of the macro. OK.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+