Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(93723)

#15014: smtplib: add support for arbitrary auth methods

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by sandro.tosi
Modified:
3 years, 9 months ago
Reviewers:
rdmurray, milan.py, barry
CC:
barry, r.david.murray, jesstess, sandro.tosi, catalin.iacob, devnull_psf.upfronthosting.co.za, zvyn
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 10

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/smtplib.rst View 1 2 3 4 5 4 chunks +31 lines, -14 lines 0 comments Download
Lib/smtplib.py View 1 2 3 4 5 4 chunks +36 lines, -16 lines 0 comments Download
Lib/test/test_smtplib.py View 1 2 3 4 5 5 chunks +73 lines, -9 lines 4 comments Download
Misc/NEWS View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5
r.david.murray
http://bugs.python.org/review/15014/diff/11981/Lib/smtplib.py File Lib/smtplib.py (right): http://bugs.python.org/review/15014/diff/11981/Lib/smtplib.py#newcode589 Lib/smtplib.py:589: def _CRAM_MD5_AUTH(self, challenge): Please make these methods public (no ...
4 years, 10 months ago #1
zvyn
I have questions/replies to two of your comments (and agree to all others). - Milan ...
4 years, 10 months ago #2
zvyn
I forgot to answer that question in test_smtplib.py :) http://bugs.python.org/review/15014/diff/11981/Lib/test/test_smtplib.py File Lib/test/test_smtplib.py (right): http://bugs.python.org/review/15014/diff/11981/Lib/test/test_smtplib.py#newcode819 Lib/test/test_smtplib.py:819: ...
4 years, 10 months ago #3
r.david.murray
http://bugs.python.org/review/15014/diff/15197/Lib/test/test_smtplib.py File Lib/test/test_smtplib.py (right): http://bugs.python.org/review/15014/diff/15197/Lib/test/test_smtplib.py#newcode823 Lib/test/test_smtplib.py:823: Heh. if you want to rename this you really ...
3 years, 9 months ago #4
barry
3 years, 9 months ago #5
Thanks for the review.  I'll make these changes and commit.

http://bugs.python.org/review/15014/diff/15197/Lib/test/test_smtplib.py
File Lib/test/test_smtplib.py (right):

http://bugs.python.org/review/15014/diff/15197/Lib/test/test_smtplib.py#newco...
Lib/test/test_smtplib.py:823: 
On 2015/07/08 23:44:20, r.david.murray wrote:
> Heh.  if you want to rename this you really ought to call it 'addr_spec' to be
> RFC compliant :)

Oh yeah, let's do that.  I renamed it because of a pyflakes warning ('email'
shadowed the import).

http://bugs.python.org/review/15014/diff/15197/Lib/test/test_smtplib.py#newco...
Lib/test/test_smtplib.py:1200: smtp.close()
On 2015/07/08 23:44:20, r.david.murray wrote:
> Shouldn't there also be a test for AUTH 'login'?

You mean SMTP.auth(), yes good catch.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+