Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

#15008: PEP 362 reference implementation for 3.3

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by yselivanov.ml
Modified:
7 years, 11 months ago
Reviewers:
jimjjewett, lists, larry, ezio.melotti, berker.peksag
CC:
brett.cannon, larry, Benjamin Peterson, ezio.melotti, eric.araujo, Yury.Selivanov, devnull_psf.upfronthosting.co.za, Alexandre Zani, Ramchandra Apte, Yury Selivanov
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 5

Patch Set 4 #

Total comments: 3

Patch Set 5 #

Total comments: 15

Patch Set 6 #

Total comments: 4

Patch Set 7 #

Total comments: 1

Patch Set 8 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/inspect.py View 1 2 3 4 5 6 7 3 chunks +772 lines, -3 lines 0 comments Download
Lib/test/test_inspect.py View 1 2 3 4 5 6 7 1 chunk +922 lines, -1 line 0 comments Download

Messages

Total messages: 14
Jim.J.Jewett
http://bugs.python.org/review/15008/diff/5143/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5143/Lib/inspect.py#newcode1786 Lib/inspect.py:1786: def format(self, *, format_name=str, Should this be a separate ...
7 years, 11 months ago #1
christian.heimes
As explained on the python-dev mailing list. Christian http://bugs.python.org/review/15008/diff/5143/Objects/methodobject.c File Objects/methodobject.c (right): http://bugs.python.org/review/15008/diff/5143/Objects/methodobject.c#newcode224 Objects/methodobject.c:224: {"__signature__", ...
7 years, 11 months ago #2
larry
http://bugs.python.org/review/15008/diff/5143/Objects/methodobject.c File Objects/methodobject.c (right): http://bugs.python.org/review/15008/diff/5143/Objects/methodobject.c#newcode224 Objects/methodobject.c:224: {"__signature__", T_OBJECT, OFF(m_signature), 0}, The object that the PEP ...
7 years, 11 months ago #3
christian.heimes
On 2012/06/16 01:56:53, larry wrote: > Christian: are modules implemented in Python shared across instances? ...
7 years, 11 months ago #4
Yury Selivanov
http://bugs.python.org/review/15008/diff/5143/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5143/Lib/inspect.py#newcode1786 Lib/inspect.py:1786: def format(self, *, format_name=str, On 2012/06/15 21:00:04, Jim.Jewett wrote: ...
7 years, 11 months ago #5
Jim.J.Jewett
http://bugs.python.org/review/15008/diff/5159/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5159/Lib/inspect.py#newcode1824 Lib/inspect.py:1824: if param.kind == _VAR_POSITIONAL: Is there a reason this ...
7 years, 11 months ago #6
Yury Selivanov
http://bugs.python.org/review/15008/diff/5159/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5159/Lib/inspect.py#newcode1824 Lib/inspect.py:1824: if param.kind == _VAR_POSITIONAL: On 2012/06/19 05:44:00, Jim.Jewett wrote: ...
7 years, 11 months ago #7
Yury Selivanov
http://bugs.python.org/review/15008/diff/5159/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5159/Lib/inspect.py#newcode1824 Lib/inspect.py:1824: if param.kind == _VAR_POSITIONAL: On 2012/06/19 17:00:59, Yury.Selivanov wrote: ...
7 years, 11 months ago #8
ezio.melotti
http://bugs.python.org/review/15008/diff/5161/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5161/Lib/inspect.py#newcode1325 Lib/inspect.py:1325: and not getattr(param, '__partial_kwarg__', False): Parentheses are preferred to ...
7 years, 11 months ago #9
Yury Selivanov
http://bugs.python.org/review/15008/diff/5161/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5161/Lib/inspect.py#newcode1325 Lib/inspect.py:1325: and not getattr(param, '__partial_kwarg__', False): On 2012/06/19 20:34:45, ezio.melotti ...
7 years, 11 months ago #10
ezio.melotti
On 2012/06/19 20:47:10, Yury.Selivanov wrote: > http://bugs.python.org/review/15008/diff/5161/Lib/inspect.py > File Lib/inspect.py (right): > > http://bugs.python.org/review/15008/diff/5161/Lib/inspect.py#newcode1325 > ...
7 years, 11 months ago #11
Jim.J.Jewett
http://bugs.python.org/review/15008/diff/5162/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5162/Lib/inspect.py#newcode1471 Lib/inspect.py:1471: # Is this has a default value that was ...
7 years, 11 months ago #12
Yury Selivanov
http://bugs.python.org/review/15008/diff/5162/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/15008/diff/5162/Lib/inspect.py#newcode1471 Lib/inspect.py:1471: # Is this has a default value that was ...
7 years, 11 months ago #13
berkerpeksag
7 years, 11 months ago #14
http://bugs.python.org/review/15008/diff/5175/Lib/inspect.py
File Lib/inspect.py (right):

http://bugs.python.org/review/15008/diff/5175/Lib/inspect.py#newcode1257
Lib/inspect.py:1257: '''Get a signature object for the passed callable.'''
Minor nit: ''' -> """

See: http://www.python.org/dev/peps/pep-0008/#documentation-strings
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+