Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

#14204: Support for the NPN extension to TLS/SSL

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by colinmarc
Modified:
8 years, 2 months ago
Reviewers:
pitrou
CC:
loewis, jcea, AntoinePitrou, marcelo_fernandez, devnull_psf.upfronthosting.co.za, colinmarc_gmail.com, ssm
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 8

Patch Set 4 #

Total comments: 1

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/ssl.rst View 4 chunks +34 lines, -1 line 0 comments Download
Lib/ssl.py View 1 2 3 4 5 6 chunks +24 lines, -3 lines 0 comments Download
Lib/test/test_ssl.py View 1 2 3 4 5 8 chunks +50 lines, -4 lines 0 comments Download
Modules/_ssl.c View 1 2 3 4 5 7 chunks +115 lines, -0 lines 0 comments Download

Messages

Total messages: 2
pitrou_free.fr
Thank you for the patch. Here is a preliminary review. http://bugs.python.org/review/14204/diff/4354/15659 File Lib/ssl.py (right): http://bugs.python.org/review/14204/diff/4354/15659#newcode93 ...
8 years, 2 months ago #1
pitrou_free.fr
8 years, 2 months ago #2
Hi,
I think the patch is almost good for commit. 
See a comment below.

http://bugs.python.org/review/14204/diff/4361/15680
File Modules/_ssl.c (right):

http://bugs.python.org/review/14204/diff/4361/15680#newcode1709
Modules/_ssl.c:1709: self->npn_protocols = PyMem_Malloc(protos.len+1);
Why "protos.len + 1" and not "protos.len"? Should there be a terminating "\0"?
If so, you have to write it at the end.

Also, you should check the PyMem_Malloc result and raise an error if it's NULL
(see http://docs.python.org/dev/c-api/exceptions.html#PyErr_NoMemory ).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+