Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37598)

#14061: Misc fixes and cleanups in archiving code in shutil and test_shutil

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by merwok
Modified:
2 years, 11 months ago
Reviewers:
vadmium+py, storchaka
CC:
Georg, nadeem.vawda, tarek_ziade.org, eric.araujo, devnull_psf.upfronthosting.co.za, Martin Panter, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Patch Set 3 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/shutil.rst View 1 2 6 chunks +24 lines, -20 lines 0 comments Download
Lib/shutil.py View 1 2 10 chunks +43 lines, -37 lines 1 comment Download
Lib/test/test_shutil.py View 1 2 11 chunks +42 lines, -49 lines 0 comments Download

Messages

Total messages: 4
Martin Panter
https://bugs.python.org/review/14061/diff/15940/Doc/library/shutil.rst File Doc/library/shutil.rst (right): https://bugs.python.org/review/14061/diff/15940/Doc/library/shutil.rst#newcode495 Doc/library/shutil.rst:495: Added support for the *xztar* format. Maybe it is ...
3 years, 11 months ago #1
storchaka_gmail.com
https://bugs.python.org/review/14061/diff/15940/Doc/library/shutil.rst File Doc/library/shutil.rst (right): https://bugs.python.org/review/14061/diff/15940/Doc/library/shutil.rst#newcode495 Doc/library/shutil.rst:495: Added support for the *xztar* format. On 2015/11/12 23:40:52, ...
3 years, 11 months ago #2
Martin Panter
https://bugs.python.org/review/14061/diff/15940/Doc/library/shutil.rst File Doc/library/shutil.rst (right): https://bugs.python.org/review/14061/diff/15940/Doc/library/shutil.rst#newcode495 Doc/library/shutil.rst:495: Added support for the *xztar* format. On 2015/11/13 10:42:16, ...
3 years, 11 months ago #3
Martin Panter
2 years, 11 months ago #4
https://bugs.python.org/review/14061/diff/19151/Lib/shutil.py
File Lib/shutil.py (right):

https://bugs.python.org/review/14061/diff/19151/Lib/shutil.py#newcode761
Lib/shutil.py:761: "bztar", or "xztar".  Or any other registered format
Might read better without the separate sentence:

one of "zip", . . ., "bztar", "xztar", or any other registered format.

Anyway, it needs another full stop at the end.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+