Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(38102)

#13633: Handling of hex character references in HTMLParser.handle_charref

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 10 months ago by ezio.melotti
Modified:
5 years, 10 months ago
Reviewers:
storchaka
CC:
ezio.melotti, eric.araujo, r.david.murray, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 28

Patch Set 2 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/html.parser.rst View 1 5 chunks +24 lines, -11 lines 0 comments Download
Lib/html/parser.py View 1 6 chunks +45 lines, -15 lines 2 comments Download
Lib/test/test_htmlparser.py View 1 7 chunks +62 lines, -8 lines 0 comments Download
Misc/NEWS View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6
storchaka_gmail.com
http://bugs.python.org/review/13633/diff/10005/Doc/library/html.parser.rst File Doc/library/html.parser.rst (right): http://bugs.python.org/review/13633/diff/10005/Doc/library/html.parser.rst#newcode23 Doc/library/html.parser.rst:23: If *convert_charrefs* is ``True`` (default: ``False``), all character "is ...
5 years, 10 months ago #1
ezio.melotti
http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py File Lib/html/parser.py (right): http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py#newcode118 Lib/html/parser.py:118: longer split in chunks), otherwise they are passed by ...
5 years, 10 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py File Lib/html/parser.py (right): http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py#newcode118 Lib/html/parser.py:118: longer split in chunks), otherwise they are passed by ...
5 years, 10 months ago #3
ezio.melotti
http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py File Lib/html/parser.py (right): http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py#newcode118 Lib/html/parser.py:118: longer split in chunks), otherwise they are passed by ...
5 years, 10 months ago #4
storchaka_gmail.com
http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py File Lib/html/parser.py (right): http://bugs.python.org/review/13633/diff/10005/Lib/html/parser.py#newcode252 Lib/html/parser.py:252: assert self.convert_charrefs == False, ( On 2013/11/23 00:20:46, ezio.melotti ...
5 years, 10 months ago #5
storchaka_gmail.com
5 years, 10 months ago #6
http://bugs.python.org/review/13633/diff/10069/Lib/html/parser.py
File Lib/html/parser.py (right):

http://bugs.python.org/review/13633/diff/10069/Lib/html/parser.py#newcode101
Lib/html/parser.py:101: _charrefs_sentinel = object()
Are there a sense in two sentinels?

http://bugs.python.org/review/13633/diff/10069/Lib/html/parser.py#newcode143
Lib/html/parser.py:143: self.convert_charrefs = False  # default
convert_charrefs = False

and remove "else" below.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+