Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(150975)

#13583: sqlite3.Row doesn't support slice indexes

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by blastocyst
Modified:
4 years, 9 months ago
Reviewers:
pitrou
CC:
gh_ghaering.de, AntoinePitrou, jesstess, devnull_psf.upfronthosting.co.za, xapple, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/sqlite3/test/factory.py View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
Modules/_sqlite/row.c View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 1
AntoinePitrou
5 years, 7 months ago #1
Thanks for the patch. I have a single comment below:

http://bugs.python.org/review/13583/diff/11737/Modules/_sqlite/row.c
File Modules/_sqlite/row.c (right):

http://bugs.python.org/review/13583/diff/11737/Modules/_sqlite/row.c#newcode149
Modules/_sqlite/row.c:149: it = src[cur];
Why not simply use PyTuple_SET_ITEM and PyTuple_GET_ITEM? That would avoid
breaking encapsulation and relying on the PyTupleObject struct.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+