Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(169998)

#13424: Add examples for open’s new opener argument

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 1 month ago by merwok
Modified:
7 years ago
Reviewers:
storchaka
CC:
ezio.melotti, eric.araujo, docs_python.org, rosslagerwall, devnull_psf.upfronthosting.co.za, storchaka, guillaumep
Visibility:
Public.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/functions.rst View 1 chunk +30 lines, -0 lines 4 comments Download
Doc/library/io.rst View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
storchaka_gmail.com
http://bugs.python.org/review/13424/diff/6494/Doc/library/functions.rst File Doc/library/functions.rst (right): http://bugs.python.org/review/13424/diff/6494/Doc/library/functions.rst#newcode938 Doc/library/functions.rst:938: The following example is an alternative implementation for opening ...
7 years, 1 month ago #1
eric.araujo
7 years ago #2
http://bugs.python.org/review/13424/diff/6494/Doc/library/functions.rst
File Doc/library/functions.rst (right):

http://bugs.python.org/review/13424/diff/6494/Doc/library/functions.rst#newco...
Doc/library/functions.rst:938: The following example is an alternative
implementation for opening files
This was an easy idea for an example, and I thought it could be easily map to
some windows API for readers.

http://bugs.python.org/review/13424/diff/6494/Doc/library/functions.rst#newco...
Doc/library/functions.rst:959: ...     dir_fd = os.open(dirname, os.O_RDONLY)
Oops!  I noticed the unclosed file objects in the first example (and judged they
were okay here) but did not catch this one.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+