Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24379)

#13266: Add inspect.unwrap(f) to easily unravel "__wrapped__" chains

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 2 months ago by ncoghlan
Modified:
5 years, 11 months ago
Reviewers:
merwok, aaron.iles, ezio.melotti, urban.dani+py
CC:
rhettinger, jcea, Nick Coghlan, ezio.melotti, eric.araujo, flox, meadori, durban, devnull_psf.upfronthosting.co.za, aliles
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 #

Total comments: 6

Patch Set 3 #

Patch Set 4 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/inspect.rst View 1 2 3 1 chunk +17 lines, -0 lines 0 comments Download
Doc/whatsnew/3.4.rst View 1 2 3 2 chunks +11 lines, -3 lines 0 comments Download
Lib/inspect.py View 1 2 3 3 chunks +37 lines, -7 lines 0 comments Download
Lib/test/test_inspect.py View 1 2 3 5 chunks +73 lines, -1 line 1 comment Download

Messages

Total messages: 6
eric.araujo
http://bugs.python.org/review/13266/diff/4751/16851 File Lib/inspect.py (right): http://bugs.python.org/review/13266/diff/4751/16851#newcode1232 Lib/inspect.py:1232: raise ValueError('wrapper loop') Idea: include the func name in ...
7 years, 2 months ago #1
aliles
Reviewed changes. Needed to make minor changes to the patches to get them to apply ...
6 years, 10 months ago #2
eric.araujo
http://bugs.python.org/review/13266/diff/4751/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/13266/diff/4751/Lib/inspect.py#newcode1221 Lib/inspect.py:1221: def unwrap(func): Yes please. http://bugs.python.org/review/13266/diff/4751/Lib/test/test_inspect.py File Lib/test/test_inspect.py (right): http://bugs.python.org/review/13266/diff/4751/Lib/test/test_inspect.py#newcode1172 ...
6 years, 10 months ago #3
ezio.melotti
http://bugs.python.org/review/13266/diff/6441/Doc/library/inspect.rst File Doc/library/inspect.rst (right): http://bugs.python.org/review/13266/diff/6441/Doc/library/inspect.rst#newcode800 Doc/library/inspect.rst:800: Get the object wrapped by *func*. If follows the ...
6 years, 7 months ago #4
durban
http://bugs.python.org/review/13266/diff/6441/Lib/inspect.py File Lib/inspect.py (right): http://bugs.python.org/review/13266/diff/6441/Lib/inspect.py#newcode373 Lib/inspect.py:373: memo = {id(func)} On 2012/11/04 05:23:39, ezio.melotti wrote: > ...
6 years, 7 months ago #5
aliles
5 years, 11 months ago #6
Patch applied to current default branch. All tests pass correctly.

http://bugs.python.org/review/13266/diff/8661/Lib/test/test_inspect.py
File Lib/test/test_inspect.py (right):

http://bugs.python.org/review/13266/diff/8661/Lib/test/test_inspect.py#newcod...
Lib/test/test_inspect.py:2322: def test_stop(self):
Should there be a parallel test case for a stop callable being provided that
never returns true?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+