Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(93939)

#13150: Most of Python's startup time is sysconfig

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by pitrou
Modified:
7 years, 6 months ago
Reviewers:
ezio.melotti
CC:
barry, terry.reedy, doko, Nick Coghlan, AntoinePitrou, haypo, nadeem.vawda, tarek_ziade.org, ezio.melotti, eric.araujo, rpetrov, Arfrever, rosslagerwall, devnull_psf.upfronthosting.co.za, jcon
Visibility:
Public.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
.hgignore View 1 chunk +1 line, -0 lines 0 comments Download
Lib/sysconfig.py View 3 chunks +16 lines, -3 lines 3 comments Download
Makefile.pre.in View 2 chunks +4 lines, -1 line 2 comments Download

Messages

Total messages: 3
ezio.melotti
http://bugs.python.org/review/13150/diff/3451/10796 File Lib/sysconfig.py (right): http://bugs.python.org/review/13150/diff/3451/10796#newcode351 Lib/sysconfig.py:351: with open(destfile, 'w', encoding='utf8') as f: I prefer utf-8. ...
7 years, 6 months ago #1
AntoinePitrou
http://bugs.python.org/review/13150/diff/3451/10796 File Lib/sysconfig.py (right): http://bugs.python.org/review/13150/diff/3451/10796#newcode351 Lib/sysconfig.py:351: with open(destfile, 'w', encoding='utf8') as f: On 2011/10/15 01:49:58, ...
7 years, 6 months ago #2
ezio.melotti
7 years, 6 months ago #3
http://bugs.python.org/review/13150/diff/3451/10796
File Lib/sysconfig.py (right):

http://bugs.python.org/review/13150/diff/3451/10796#newcode351
Lib/sysconfig.py:351: with open(destfile, 'w', encoding='utf8') as f:
On 2011/10/15 13:30:16, AntoinePitrou wrote:
> On 2011/10/15 01:49:58, ezio.melotti wrote:
> > I prefer utf-8.
> 
> Ah... Any reason?
> 

That's the official name[0] (actually is UTF-8, but I don't think the casing
matters).  There was also an issue where utf-8 was faster because it had a
fast-path, but utf8 had to go through a codec lookup, but that should be fixed
now.

[0]: http://www.iana.org/assignments/character-sets
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+