Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(74582)

#12965: longobject: documentation improvements

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by stefan
Modified:
7 years, 11 months ago
Reviewers:
zbyszek
CC:
mark.dickinson, skrah, docs_python.org, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/long.rst View 4 chunks +95 lines, -60 lines 5 comments Download
Objects/longobject.c View 4 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 1
Z. Jędrzejewski-Szmek
7 years, 11 months ago #1
http://bugs.python.org/review/12965/diff/3318/10329
File Doc/c-api/long.rst (right):

http://bugs.python.org/review/12965/diff/3318/10329#newcode118
Doc/c-api/long.rst:118: *obj* can be a :c:type:`PyLongObject`, a subtype of
:c:type:`PyLongObject`
comma missing

http://bugs.python.org/review/12965/diff/3318/10329#newcode122
Doc/c-api/long.rst:122: If *obj* is out of bounds, raise :exc:`OverflowError`.
Maybe change 'out of bounds' to 'outside of representable range', because 'out
of bounds' seems to imply that the original object is somehow wrong?

http://bugs.python.org/review/12965/diff/3318/10329#newcode127
Doc/c-api/long.rst:127: :c:type:`PyLongObject`, a subtype of
:c:type:`PyLongObject` or
comma missing

http://bugs.python.org/review/12965/diff/3318/10329#newcode130
Doc/c-api/long.rst:130: If *obj* is greater than :const:`LONG_MAX` or less than
:const:`LONG_MIN`, set
s/less/smaller/ (as the opposite of 'greater')

http://bugs.python.org/review/12965/diff/3318/10329#newcode143
Doc/c-api/long.rst:143: *obj* can be a :c:type:`PyLongObject`, a subtype of
:c:type:`PyLongObject`
comma missing
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+