Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1067)

#12890: cgitb displays <p> tags when executed in text mode

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by mcjeff
Modified:
5 years, 2 months ago
Reviewers:
merwok
CC:
ezio.melotti, eric.araujo, r.david.murray, mcjeff, devnull_psf.upfronthosting.co.za, aliles, mjdorma, sptonkin
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_cgitb.py View 1 2 3 4 5 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 3
eric.araujo
Thanks for the patch. http://bugs.python.org/review/12890/diff/3289/10238 File Lib/cgitb.py (right): http://bugs.python.org/review/12890/diff/3289/10238#newcode297 Lib/cgitb.py:297: self.file.write('<p>' if self.format == 'html' ...
6 years, 2 months ago #1
eric.araujo
http://bugs.python.org/review/12890/diff/3683/11593 File Lib/cgitb.py (right): http://bugs.python.org/review/12890/diff/3683/11593#newcode305 Lib/cgitb.py:305: msg = 'Tried to save traceback to %s, but ...
6 years, 1 month ago #2
jeff_jmcneil.net
6 years, 1 month ago #3
Fixed in subsequent update. My apologies for that one.

http://bugs.python.org/review/12890/diff/3683/11593
File Lib/cgitb.py (right):

http://bugs.python.org/review/12890/diff/3683/11593#newcode305
Lib/cgitb.py:305: msg = 'Tried to save traceback to %s, but failed.' % tag
On 2011/11/21 14:54:59, eric.araujo wrote:
> This change looks unwanted.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7