Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77139)

#12834: PyBuffer_ToContiguous() incorrect for non-contiguous arrays

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by stefan
Modified:
7 years ago
Reviewers:
ncoghlan
CC:
loewis, Georg, Nick Coghlan, sasha, AntoinePitrou, haypo, christian.heimes, Benjamin Peterson, skrah, meadori, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/abstract.h View 1 chunk +0 lines, -3 lines 1 comment Download
Include/memoryobject.h View 1 chunk +2 lines, -0 lines 1 comment Download
Lib/test/test_buffer.py View 5 chunks +290 lines, -1 line 0 comments Download
Modules/_testbuffer.c View 2 chunks +44 lines, -0 lines 0 comments Download
Objects/abstract.c View 1 chunk +0 lines, -56 lines 1 comment Download
Objects/bytearrayobject.c View 1 chunk +1 line, -1 line 0 comments Download
Objects/bytesobject.c View 1 chunk +0 lines, -1 line 0 comments Download
Objects/memoryobject.c View 5 chunks +70 lines, -7 lines 0 comments Download

Messages

Total messages: 1
Nick Coghlan
7 years ago #1
Aside from not moving the function declaration, looks good to me.

http://bugs.python.org/review/12834/diff/5511/Include/abstract.h
File Include/abstract.h (left):

http://bugs.python.org/review/12834/diff/5511/Include/abstract.h#oldcode539
Include/abstract.h:539: Py_ssize_t len, char fort);
This is still an abstract API, so it should stay in this header file. Just add a
comment to abstract.c saying it's actually implemented with the rest of the
memory view code.

http://bugs.python.org/review/12834/diff/5511/Include/memoryobject.h
File Include/memoryobject.h (right):

http://bugs.python.org/review/12834/diff/5511/Include/memoryobject.h#newcode29
Include/memoryobject.h:29: Py_ssize_t len, char order);
See previous comment

http://bugs.python.org/review/12834/diff/5511/Objects/abstract.c
File Objects/abstract.c (left):

http://bugs.python.org/review/12834/diff/5511/Objects/abstract.c#oldcode448
Objects/abstract.c:448: /* view is not checked for consistency in either of
these.  It is
Add a comment here noting that the actual location of the implementation.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+