Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(27433)

#12555: PEP 3151 implementation

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by pitrou
Modified:
7 years, 9 months ago
Reviewers:
ezio.melotti, stefan-usenet, ncoghlan
CC:
barry, Nick Coghlan, AntoinePitrou, nadeem.vawda, dirkjan_ochtman.nl, eric.araujo, Arfrever, Trundle, skrah, devnull_psf.upfronthosting.co.za, Petri Lehtinen, python_xiri.fr, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Total comments: 17

Patch Set 7 #

Patch Set 8 #

Total comments: 3

Patch Set 9 #

Patch Set 10 #

Total comments: 6

Patch Set 11 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_pep3151.py View 3 chunks +55 lines, -5 lines 0 comments Download
Objects/exceptions.c View 1 2 3 4 5 6 7 8 9 10 6 chunks +159 lines, -57 lines 0 comments Download

Messages

Total messages: 9
ezio.melotti
http://bugs.python.org/review/12555/diff/3172/9851 File Include/pyerrors.h (right): http://bugs.python.org/review/12555/diff/3172/9851#newcode171 Include/pyerrors.h:171: PyAPI_DATA(PyObject *) PyExc_FileSystemError; Shouldn't this be FilesystemError? http://bugs.python.org/review/12555/diff/3172/9855 File ...
8 years, 1 month ago #1
AntoinePitrou
http://bugs.python.org/review/12555/diff/3172/9851 File Include/pyerrors.h (right): http://bugs.python.org/review/12555/diff/3172/9851#newcode171 Include/pyerrors.h:171: PyAPI_DATA(PyObject *) PyExc_FileSystemError; On 2011/08/20 20:45:15, ezio.melotti wrote: > ...
8 years, 1 month ago #2
ezio.melotti
http://bugs.python.org/review/12555/diff/3172/9851 File Include/pyerrors.h (right): http://bugs.python.org/review/12555/diff/3172/9851#newcode171 Include/pyerrors.h:171: PyAPI_DATA(PyObject *) PyExc_FileSystemError; > The exception is currently spelt ...
8 years, 1 month ago #3
AntoinePitrou
> http://bugs.python.org/review/12555/diff/3172/9851#newcode171 > Include/pyerrors.h:171: PyAPI_DATA(PyObject *) PyExc_FileSystemError; > > The exception is currently spelt FileSystemError, ...
8 years, 1 month ago #4
ezio.melotti
On 2011/08/20 21:31:38, AntoinePitrou wrote: > I don't really have any preference. Perhaps you want ...
8 years, 1 month ago #5
stefan-usenet_bytereef.org
http://bugs.python.org/review/12555/diff/3277/10211 File Objects/exceptions.c (right): http://bugs.python.org/review/12555/diff/3277/10211#newcode632 Objects/exceptions.c:632: newargs = PyTuple_New(nargs); I think myerrno will leak if ...
8 years ago #6
stefan-usenet_bytereef.org
http://bugs.python.org/review/12555/diff/3277/10211 File Objects/exceptions.c (right): http://bugs.python.org/review/12555/diff/3277/10211#newcode672 Objects/exceptions.c:672: /* self->filename will remain Py_None otherwise */ I guess ...
8 years ago #7
Nick Coghlan
Looks good to me from a functional point of view, just a few suggestions to: ...
7 years, 9 months ago #8
Nick Coghlan
7 years, 9 months ago #9
Updated patch looks good to me.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+