Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(68200)

#12428: functools test coverage

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by hardbyte
Modified:
6 years, 10 months ago
Reviewers:
merwok, ezio.melotti
CC:
rhettinger, Nick Coghlan, AntoinePitrou, jackdied, ezio.melotti, eric.araujo, Brian, devnull_psf.upfronthosting.co.za, eric.snow
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Total comments: 11

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/functools.py View 1 2 3 4 3 chunks +28 lines, -1 line 0 comments Download
Lib/test/test_functools.py View 1 2 3 4 21 chunks +136 lines, -72 lines 0 comments Download
Misc/ACKS View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
Misc/NEWS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3
eric.araujo
Thanks for the patch. A few comments follow. http://bugs.python.org/review/12428/diff/2942/7641 File Lib/functools.py (right): http://bugs.python.org/review/12428/diff/2942/7641#newcode95 Lib/functools.py:95: @staticmethod ...
7 years, 11 months ago #1
ezio.melotti
I left a few comments. Some are not directly related to the code you added, ...
7 years, 6 months ago #2
eric.araujo
7 years, 6 months ago #3
http://bugs.python.org/review/12428/diff/3117/9664
File Lib/test/test_functools.py (right):

http://bugs.python.org/review/12428/diff/3117/9664#newcode41
Lib/test/test_functools.py:41: class TestPartial(unittest.TestCase):
Yep, +1.  (Also self.partial reads much better than self.thetype.)

http://bugs.python.org/review/12428/diff/3117/9664#newcode208
Lib/test/test_functools.py:208: def test_pickle(self): pass
Please don’t put many statements one the same line.

http://bugs.python.org/review/12428/diff/3117/9664#newcode449
Lib/test/test_functools.py:449: class CmpToKeyTests(object):
This change is not necessary, please revert it.

http://bugs.python.org/review/12428/diff/3117/9664#newcode532
Lib/test/test_functools.py:532: module = c_functools
As above, you could set cmp_to_key = c_functools.cmp_to_key.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+