Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(295)

#12411: cgi.parse_multipart is broken on 3.x

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by veers
Modified:
5 years, 5 months ago
Reviewers:
ezio.melotti, senthil
CC:
gvanrossum, orsenthil, haypo, glyph_twistedmatrix.com, eric.araujo, jonas.wagner, r.david.murray, me_evanfosmark.com, milesck_umich.edu, mhordecki_gmail.com, flox, pierre.quentel_gmail.com, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/cgi.py View 4 chunks +9 lines, -9 lines 0 comments Download
Lib/test/test_cgi.py View 1 3 chunks +26 lines, -0 lines 4 comments Download

Messages

Total messages: 2
ezio.melotti
http://bugs.python.org/review/12411/diff/2980/Lib/test/test_cgi.py File Lib/test/test_cgi.py (right): http://bugs.python.org/review/12411/diff/2980/Lib/test/test_cgi.py#newcode127 Lib/test/test_cgi.py:127: expected = {'submit': [b' Add '], 'id': [b'1234'], 'file': ...
5 years, 5 months ago #1
orsenthil
5 years, 5 months ago #2
Making the changes suggested by Ezio.

http://bugs.python.org/review/12411/diff/2980/Lib/test/test_cgi.py
File Lib/test/test_cgi.py (right):

http://bugs.python.org/review/12411/diff/2980/Lib/test/test_cgi.py#newcode127
Lib/test/test_cgi.py:127: expected = {'submit': [b' Add '], 'id': [b'1234'],
'file': [b'Testing 123.\n'], 'title': [b'']}
On 2013/01/22 20:31:21, ezio.melotti wrote:
> A few minor nits:
> The second line of "env" should be indented under 'boundary'.
> The "expected" line is too long, and should be broken on 2 lines.
> latin-1 could be replaced by latin1.

Done.

http://bugs.python.org/review/12411/diff/2980/Lib/test/test_cgi.py#newcode142
Lib/test/test_cgi.py:142: self.assertTrue(bool(fs))
On 2013/01/22 20:31:21, ezio.melotti wrote:
> The 2 bool() here are not necessary.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7