Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(96467)

#12077: Harmonizing descriptor protocol documentation

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by sorcio
Modified:
6 years, 9 months ago
Reviewers:
berker.peksag
CC:
rhettinger, nedbat, ezio.melotti, eric.araujo, durban, docs_python.org, davide.rizzo, parlar_gmail.com, Martin Panter, kushou
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/howto/descriptor.rst View 1 11 chunks +121 lines, -84 lines 0 comments Download

Messages

Total messages: 1
berkerpeksag
6 years, 9 months ago #1
http://bugs.python.org/review/12077/diff/7351/Doc/howto/descriptor.rst
File Doc/howto/descriptor.rst (right):

http://bugs.python.org/review/12077/diff/7351/Doc/howto/descriptor.rst#newcod...
Doc/howto/descriptor.rst:393: '''Emulate PyStaticMethod_Type() in
Objects/funcobject.c'''
Nit: I would use triple quotes.

See PEP 257:

"For consistency, always use """triple double quotes""" around docstrings."

http://www.python.org/dev/peps/pep-0257/

http://bugs.python.org/review/12077/diff/7351/Doc/howto/descriptor.rst#newcod...
Doc/howto/descriptor.rst:419: is to create alternate class constructors.  In
Python 2.3, the classmethod
Python 2.3 is almost 10 years old. I think this part can be deleted (at least in
Python 3).
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+