Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

#12006: strptime should implement %V or %u directive from libc

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 4 months ago by ec
Modified:
2 years ago
Reviewers:
alexander.belopolsky, storchaka, berker.peksag, aganders3
CC:
tim.peters, sasha, r.david.murray, BreamoreBoy, Erik.Cederstrand, devnull_psf.upfronthosting.co.za, shiny.magnum_googlemail.com, ash, berkerpeksag, storchaka, erik_cederstrand.dk, Alex.Willmer
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 2

Patch Set 6 #

Total comments: 12

Patch Set 7 #

Patch Set 8 #

Total comments: 5

Patch Set 9 #

Total comments: 2

Patch Set 10 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/datetime.rst View 1 2 3 4 5 6 7 8 9 2 chunks +36 lines, -1 line 0 comments Download
Doc/whatsnew/3.6.rst View 1 2 3 4 5 6 7 8 9 1 chunk +8 lines, -0 lines 0 comments Download
Lib/_strptime.py View 1 2 3 4 5 6 7 8 9 7 chunks +68 lines, -13 lines 0 comments Download
Lib/test/test_strptime.py View 1 2 3 4 5 6 7 8 9 5 chunks +44 lines, -13 lines 0 comments Download
Misc/NEWS View 1 2 3 4 5 6 7 8 9 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
belopolsky_users.sourceforge.net
http://bugs.python.org/review/12006/diff/2694/6525 File Lib/_strptime.py (right): http://bugs.python.org/review/12006/diff/2694/6525#newcode370 Lib/_strptime.py:370: iso_weekday = -1 Duplicated line. Do you actually need ...
6 years, 4 months ago #1
sasha
http://bugs.python.org/review/12006/diff/12746/Lib/test/test_strptime.py File Lib/test/test_strptime.py (right): http://bugs.python.org/review/12006/diff/12746/Lib/test/test_strptime.py#newcode461 Lib/test/test_strptime.py:461: for directive in ('W', 'U', 'V'): This will be ...
3 years ago #2
storchaka_gmail.com
http://bugs.python.org/review/12006/diff/12746/Lib/_strptime.py File Lib/_strptime.py (right): http://bugs.python.org/review/12006/diff/12746/Lib/_strptime.py#newcode433 Lib/_strptime.py:433: weekday = locale_time.f_weekday.index(found_dict['A'].lower()) If %A or %a is used, ...
2 years, 7 months ago #3
berkerpeksag
http://bugs.python.org/review/12006/diff/14264/Doc/library/datetime.rst File Doc/library/datetime.rst (right): http://bugs.python.org/review/12006/diff/14264/Doc/library/datetime.rst#newcode1920 Doc/library/datetime.rst:1920: | | .. versionadded:: 3.5 | | | You ...
2 years, 7 months ago #4
storchaka_gmail.com
http://bugs.python.org/review/12006/diff/14264/Doc/library/datetime.rst File Doc/library/datetime.rst (right): http://bugs.python.org/review/12006/diff/14264/Doc/library/datetime.rst#newcode1920 Doc/library/datetime.rst:1920: | | .. versionadded:: 3.5 | | | On ...
2 years, 7 months ago #5
storchaka_gmail.com
http://bugs.python.org/review/12006/diff/15313/Lib/_strptime.py File Lib/_strptime.py (right): http://bugs.python.org/review/12006/diff/15313/Lib/_strptime.py#newcode374 Lib/_strptime.py:374: found_keys = frozenset(found_dict.keys()) What the purpose of this change? ...
2 years, 2 months ago #6
sasha
http://bugs.python.org/review/12006/diff/15328/Doc/library/datetime.rst File Doc/library/datetime.rst (right): http://bugs.python.org/review/12006/diff/15328/Doc/library/datetime.rst#newcode1909 Doc/library/datetime.rst:1909: may may not be available on all platforms when ...
2 years ago #7
ash
2 years ago #8
http://bugs.python.org/review/12006/diff/15328/Doc/library/datetime.rst
File Doc/library/datetime.rst (right):

http://bugs.python.org/review/12006/diff/15328/Doc/library/datetime.rst#newco...
Doc/library/datetime.rst:1909: may may not be available on all platforms when
used with the :meth:`strftime`
> "may may" - missing "or"?

Good catch. I think actually just using "may" once will fix it.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7