Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11896)

#11939: Implement stat.st_dev and os.path.samefile on windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by amauryfa
Modified:
6 years, 8 months ago
Reviewers:
storchaka, brian
CC:
amaury.forgeotdarc, brian.curtin, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Total comments: 4

Patch Set 2 #

Patch Set 3 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/os.path.rst View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
Lib/genericpath.py View 1 2 2 chunks +27 lines, -1 line 0 comments Download
Lib/ntpath.py View 1 2 1 chunk +0 lines, -17 lines 3 comments Download
Lib/posixpath.py View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
Lib/test/test_genericpath.py View 1 2 1 chunk +68 lines, -0 lines 0 comments Download
Lib/test/test_posixpath.py View 1 2 2 chunks +0 lines, -62 lines 0 comments Download
Modules/posixmodule.c View 1 2 3 chunks +2 lines, -26 lines 0 comments Download

Messages

Total messages: 5
storchaka_gmail.com
Documentation update needed (availability, versionchanged). http://bugs.python.org/review/11939/diff/6890/Lib/genericpath.py File Lib/genericpath.py (right): http://bugs.python.org/review/11939/diff/6890/Lib/genericpath.py#newcode97 Lib/genericpath.py:97: def sameopenfile(fp1, fp2): Since ...
6 years, 8 months ago #1
brian.curtin
http://bugs.python.org/review/11939/diff/6890/Lib/genericpath.py File Lib/genericpath.py (right): http://bugs.python.org/review/11939/diff/6890/Lib/genericpath.py#newcode97 Lib/genericpath.py:97: def sameopenfile(fp1, fp2): On 2012/12/24 22:18:11, storchaka wrote: > ...
6 years, 8 months ago #2
storchaka_gmail.com
http://bugs.python.org/review/11939/diff/6897/Lib/ntpath.py File Lib/ntpath.py (right): http://bugs.python.org/review/11939/diff/6897/Lib/ntpath.py#newcode20 Lib/ntpath.py:20: "samefile", "sameopenfile",] "samestat"?
6 years, 8 months ago #3
brian.curtin
http://bugs.python.org/review/11939/diff/6897/Lib/ntpath.py File Lib/ntpath.py (right): http://bugs.python.org/review/11939/diff/6897/Lib/ntpath.py#newcode20 Lib/ntpath.py:20: "samefile", "sameopenfile",] On 2012/12/25 09:44:08, storchaka wrote: > "samestat"? ...
6 years, 8 months ago #4
storchaka_gmail.com
6 years, 8 months ago #5
http://bugs.python.org/review/11939/diff/6897/Lib/ntpath.py
File Lib/ntpath.py (right):

http://bugs.python.org/review/11939/diff/6897/Lib/ntpath.py#newcode20
Lib/ntpath.py:20: "samefile", "sameopenfile",]
On 2012/12/26 13:59:34, brian.curtin wrote:
> On 2012/12/25 09:44:08, storchaka wrote:
> > "samestat"?
> 
> That was never a part of this list so I'd rather not add it in.

Of course, samestat() was not available on Windows. Your patch adds Windows
support.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+