Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(167)

#11734: Add half-float (16-bit) support to struct module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by wickedgrey
Modified:
1 year, 3 months ago
Reviewers:
dickinsm, pitrou
CC:
rhettinger, mark.dickinson, sasha, AntoinePitrou, asvetlov, devnull_psf.upfronthosting.co.za, Eli.Stevens, mwwiebe_gmail.com, phoffman_proper.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 4

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Total comments: 6

Patch Set 8 #

Patch Set 9 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/struct.rst View 1 2 3 4 5 6 7 8 4 chunks +20 lines, -3 lines 0 comments Download
Include/floatobject.h View 1 2 3 4 5 6 7 8 3 chunks +6 lines, -4 lines 0 comments Download
Lib/test/test_struct.py View 1 2 3 4 5 6 7 8 3 chunks +105 lines, -2 lines 0 comments Download
Modules/_struct.c View 1 2 3 4 5 6 7 8 11 chunks +75 lines, -1 line 0 comments Download
Objects/floatobject.c View 1 2 3 4 5 6 7 8 2 chunks +183 lines, -1 line 0 comments Download

Messages

Total messages: 4
mark.dickinson
http://bugs.python.org/review/11734/diff/2334/5488 File Objects/floatobject.c (right): http://bugs.python.org/review/11734/diff/2334/5488#newcode2074 Objects/floatobject.c:2074: else { May be neater to deal with the ...
6 years, 8 months ago #1
AntoinePitrou
I cannot comment on the conversion functions, but a couple comments on the tests. http://bugs.python.org/review/11734/diff/13866/Lib/test/test_struct.py ...
2 years, 10 months ago #2
AntoinePitrou
https://bugs.python.org/review/11734/diff/13866/Modules/_struct.c File Modules/_struct.c (right): https://bugs.python.org/review/11734/diff/13866/Modules/_struct.c#newcode487 Modules/_struct.c:487: #if PY_LITTLE_ENDIAN Why doesn't this use unpack_halffloat()? Also, I ...
1 year, 3 months ago #3
mark.dickinson
1 year, 3 months ago #4
https://bugs.python.org/review/11734/diff/13866/Modules/_struct.c
File Modules/_struct.c (right):

https://bugs.python.org/review/11734/diff/13866/Modules/_struct.c#newcode487
Modules/_struct.c:487: #if PY_LITTLE_ENDIAN
On 2016/08/30 12:32:13, AntoinePitrou wrote:
> Why doesn't this use unpack_halffloat()?

Good catch. This even looks wrong in the (somewhat rare) case that
`_PyFloat_Unpack2` sets an exception. I'll look into the `pack_halffloat`
possibility.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7