Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32296)

#11682: PEP 380 reference implementation for 3.3

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by ncoghlan
Modified:
7 years, 9 months ago
Reviewers:
benjamin, merwok, zbyszek
CC:
rhettinger, gcewing_users.sourceforge.net, Nick Coghlan, rndblnch_gmail.com, ron_adam, aronacher, eric.araujo, alex, rfk, asvetlov, Z. Jędrzejewski-Szmek, Yury.Selivanov, ron_adam, rhettinger
Visibility:
Public.

Patch Set 1 #

Total comments: 41

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/dis.rst View 1 chunk +7 lines, -0 lines 0 comments Download
Doc/library/exceptions.rst View 2 4 1 chunk +10 lines, -1 line 0 comments Download
Doc/reference/expressions.rst View 2 4 4 chunks +27 lines, -3 lines 0 comments Download
Doc/reference/simple_stmts.rst View 2 4 3 chunks +18 lines, -6 lines 0 comments Download
Doc/whatsnew/3.3.rst View 1 3 4 2 chunks +16 lines, -1 line 0 comments Download
Grammar/Grammar View 1 3 4 2 chunks +3 lines, -2 lines 0 comments Download
Include/frameobject.h View 1 3 4 1 chunk +1 line, -0 lines 0 comments Download
Include/genobject.h View 1 3 4 1 chunk +1 line, -0 lines 0 comments Download
Include/graminit.h View 1 3 4 1 chunk +1 line, -0 lines 0 comments Download
Include/opcode.h View 1 3 4 1 chunk +1 line, -0 lines 0 comments Download
Include/pyerrors.h View 1 3 4 2 chunks +7 lines, -0 lines 0 comments Download
Include/Python-ast.h View 1 3 4 2 chunks +4 lines, -2 lines 0 comments Download
Lib/opcode.py View 1 3 4 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_ast.py View 3 4 1 chunk +2 lines, -1 line 0 comments Download
Lib/test/test_generators.py View 1 3 4 3 chunks +0 lines, -42 lines 0 comments Download
Lib/test/test_grammar.py View 1 3 4 1 chunk +32 lines, -0 lines 0 comments Download
Lib/test/test_parser.py View 1 3 4 2 chunks +4 lines, -1 line 0 comments Download
Lib/test/test_pep380.py View 1 3 4 1 chunk +842 lines, -0 lines 0 comments Download
Lib/test/test_sys.py View 1 3 4 1 chunk +1 line, -1 line 0 comments Download
Misc/ACKS View 1 3 4 2 chunks +2 lines, -0 lines 0 comments Download
Misc/NEWS View 1 3 4 1 chunk +4 lines, -0 lines 0 comments Download
Modules/parsermodule.c View 1 3 4 3 chunks +39 lines, -12 lines 3 comments Download
Objects/abstract.c View 3 4 2 chunks +0 lines, -2 lines 0 comments Download
Objects/exceptions.c View 1 3 4 1 chunk +67 lines, -2 lines 1 comment Download
Objects/frameobject.c View 1 3 4 5 chunks +10 lines, -5 lines 0 comments Download
Objects/genobject.c View 1 3 4 9 chunks +206 lines, -13 lines 0 comments Download
Parser/Python.asdl View 1 3 4 1 chunk +1 line, -1 line 0 comments Download
Python/ast.c View 1 3 4 3 chunks +16 lines, -5 lines 0 comments Download
Python/ceval.c View 1 3 4 1 chunk +46 lines, -0 lines 0 comments Download
Python/compile.c View 1 3 4 2 chunks +7 lines, -1 line 0 comments Download
Python/graminit.c View 1 3 4 3 chunks +104 lines, -86 lines 0 comments Download
Python/opcode_targets.h View 1 3 4 1 chunk +1 line, -1 line 0 comments Download
Python/Python-ast.c View 1 3 4 6 chunks +24 lines, -3 lines 0 comments Download
Python/symtable.c View 1 3 4 3 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 5
Benjamin Peterson
The most pressing issue is the hideousness of test_pop380.py. On a more minor front, tests ...
8 years, 3 months ago #1
Nick Coghlan
Modified these in my local copy, also picked up on a few more opportunities to ...
8 years, 1 month ago #2
Nick Coghlan
Missed flagging this comment on the previous pass. http://bugs.python.org/review/11682/diff/3013/7860 File Include/pyerrors.h (right): http://bugs.python.org/review/11682/diff/3013/7860#newcode365 Include/pyerrors.h:365: PyAPI_FUNC(PyObject ...
8 years, 1 month ago #3
eric.araujo
A few style comments and suggestions for wording. http://bugs.python.org/review/11682/diff/3360/10455 File Doc/library/exceptions.rst (right): http://bugs.python.org/review/11682/diff/3360/10455#newcode266 Doc/library/exceptions.rst:266: further ...
8 years, 1 month ago #4
Z. Jędrzejewski-Szmek
7 years, 9 months ago #5
Some very minor comments.

http://bugs.python.org/review/11682/diff/3982/13233
File Modules/parsermodule.c (left):

http://bugs.python.org/review/11682/diff/3982/13233#oldcode2671
Modules/parsermodule.c:2671: if (res && (nch == 2))
Other ifs don't have braces -- this one is out of style.

http://bugs.python.org/review/11682/diff/3982/13233
File Modules/parsermodule.c (right):

http://bugs.python.org/review/11682/diff/3982/13233#newcode1652
Modules/parsermodule.c:1652: if (nch == 2) {
nch was tested to be (>=1 && <=2) above. This second test is unnecessary.

http://bugs.python.org/review/11682/diff/3982/13233#newcode1671
Modules/parsermodule.c:1671: else if (nch == 2) {
Indentation here (off-by-one-space)

Also I think the whole if..ifelse..else could be a switch statement.

http://bugs.python.org/review/11682/diff/3982/13235
File Objects/exceptions.c (right):

http://bugs.python.org/review/11682/diff/3982/13235#newcode492
Objects/exceptions.c:492: //                       "Signal the end from
iterator.__next__().");
Remove this comment?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+