Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(159254)

#11390: doctest: add cmdline parameters

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by techtonik
Modified:
6 years, 4 months ago
Reviewers:
barry, rdmurray
CC:
barry, haypo, techtonik, ezio.melotti, r.david.murray, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/test/test_doctest.py View 1 2 3 2 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 2
barry
+1 http://bugs.python.org/review/11390/diff/8450/Lib/doctest.py File Lib/doctest.py (right): http://bugs.python.org/review/11390/diff/8450/Lib/doctest.py#newcode2729 Lib/doctest.py:2729: verbose = True if args.verbose else False This ...
6 years, 5 months ago #1
r.david.murray
6 years, 5 months ago #2
Thanks for the review.

http://bugs.python.org/review/11390/diff/8450/Lib/doctest.py
File Lib/doctest.py (right):

http://bugs.python.org/review/11390/diff/8450/Lib/doctest.py#newcode2729
Lib/doctest.py:2729: verbose = True if args.verbose else False
On 2013/06/22 17:07:38, barry wrote:
> This one seems weird.  Won't args.verbose already be True or False?  And if
not,
> why not just bool(args.verbose)?

Heh.  The way I coded it the default is None, but there's no good reason for
that.  Will fix.

http://bugs.python.org/review/11390/diff/8450/Lib/doctest.py#newcode2734
Lib/doctest.py:2734: options |= FAIL_FAST
On 2013/06/22 17:07:38, barry wrote:
> The help string should probably say that -f is added in addition to any -o
> options, just to make it clear.

Good idea.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+