Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(195222)

#11352: Update cgi module doc

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by pierre.quentel
Modified:
4 years, 10 months ago
Reviewers:
berker.peksag, jimjjewett
CC:
amaury.forgeotdarc, ggenellina_gmail.com, orsenthil, haypo, aharrin_luc.edu, v+python, r.david.murray, myoopos_gmail.com, harthie_yahoo.fr, fatbull_web.de, flox, sandro.tosi, docs_python.org, pierre.quentel_gmail.com, tkadm30_yandex.com, devnull_psf.upfronthosting.co.za, berkerpeksag, Jim.J.Jewett, mutley89, levkivskyi
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Total comments: 21

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/cgi.rst View 1 2 3 5 chunks +117 lines, -117 lines 0 comments Download

Messages

Total messages: 2
berkerpeksag
http://bugs.python.org/review/11352/diff/4862/Doc/library/cgi.rst File Doc/library/cgi.rst (left): http://bugs.python.org/review/11352/diff/4862/Doc/library/cgi.rst#oldcode255 Doc/library/cgi.rst:255: It would be great to add a complete working ...
5 years, 8 months ago #1
Jim.J.Jewett
5 years, 8 months ago #2
http://bugs.python.org/review/11352/diff/4862/Doc/library/cgi.rst
File Doc/library/cgi.rst (right):

http://bugs.python.org/review/11352/diff/4862/Doc/library/cgi.rst#newcode32
Doc/library/cgi.rst:32: submitted through an HTML ``<FORM>`` element.
Marking for posterity:  ISINDEX is obsolete, but still supported.  This change
is OK anyhow because of the "usually".

http://bugs.python.org/review/11352/diff/4862/Doc/library/cgi.rst#newcode95
Doc/library/cgi.rst:95: consume standard input, it should be instantiated only
once.
Once once per what?  Per Request?  Per process?  Per process until the previous
instantiation has finished its work, and can be finalized?

http://bugs.python.org/review/11352/diff/4862/Doc/library/cgi.rst#newcode99
Doc/library/cgi.rst:99: is usually contained in the META tag in the HEAD section
of the HTML
Also, "in a META element", rather than *the* element.

Also, encoding depends on the data uploaded, not just on the form sent.  I'm not
sure how to word that, but here is a try:

The *encoding* and *errors* parameters indicate how to decode the bytes into
text strings.  (See the :mod:`str` documentation.)  The default assumption is
ASCII, with any other characters causing an exception to be raised.  Often, a
better guess is available, typically from application- (or form-) specific
knowledge, a :mailheader:`Content-Type` header's `charset` attribute, or a 
``<META>`` element.


Note that I agree a link might be better still; I'm just not sure how to do it.

http://bugs.python.org/review/11352/diff/4862/Doc/make.bat
File Doc/make.bat (right):

http://bugs.python.org/review/11352/diff/4862/Doc/make.bat#newcode5
Doc/make.bat:5: if "%PYTHON%" EQU "" set PYTHON=c:/python27/python.exe
This seems like a change to for bootstrapping or cross-compiling -- unrelated to
the doc changes.

http://bugs.python.org/review/11352/diff/4862/Lib/http/server.py
File Lib/http/server.py (right):

http://bugs.python.org/review/11352/diff/4862/Lib/http/server.py#newcode1167
Lib/http/server.py:1167: stdin=stdin,
This change is not just documentation, and should probably be discussed
separately.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+