Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92760)

#11016: Add S_ISDOOR to the stat module

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 3 months ago by pitrou
Modified:
6 years, 2 months ago
Reviewers:
lists
CC:
loewis, jcea, AntoinePitrou, haypo, movement_users.sourceforge.net, giampaolo.rodola, christian.heimes, Arfrever, r.david.murray, Charles-Fran├žois Natali, devnull_psf.upfronthosting.co.za, stefan_drees.name
Visibility:
Public.

Patch Set 1 #

Total comments: 15

Patch Set 2 #

Patch Set 3 #

Total comments: 2

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Modules/_stat.c View 1 2 3 4 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5
AntoinePitrou
A couple of comments below. Overall, good idea :) http://bugs.python.org/review/11016/diff/8083/Lib/stat.py File Lib/stat.py (right): http://bugs.python.org/review/11016/diff/8083/Lib/stat.py#newcode1 Lib/stat.py:1: ...
6 years, 3 months ago #1
AntoinePitrou
http://bugs.python.org/review/11016/diff/8083/Modules/statmodule.c File Modules/statmodule.c (right): http://bugs.python.org/review/11016/diff/8083/Modules/statmodule.c#newcode25 Modules/statmodule.c:25: #ifndef S_IFMT Answering to myself: these are pretty widespead ...
6 years, 3 months ago #2
christian.heimes
http://bugs.python.org/review/11016/diff/8083/Lib/stat.py File Lib/stat.py (right): http://bugs.python.org/review/11016/diff/8083/Lib/stat.py#newcode1 Lib/stat.py:1: """Constants/functions for interpreting results of os.stat() and os.lstat(). On ...
6 years, 3 months ago #3
AntoinePitrou
http://bugs.python.org/review/11016/diff/8083/Modules/statmodule.c File Modules/statmodule.c (right): http://bugs.python.org/review/11016/diff/8083/Modules/statmodule.c#newcode7 Modules/statmodule.c:7: #ifdef __cplusplus On 2013/05/07 14:17:10, christian.heimes wrote: > On ...
6 years, 3 months ago #4
AntoinePitrou
6 years, 2 months ago #5
Just two comments about the horrible stuff, I haven't had any time to look at
the rest.

http://bugs.python.org/review/11016/diff/8445/Lib/stat.py
File Lib/stat.py (right):

http://bugs.python.org/review/11016/diff/8445/Lib/stat.py#newcode6
Lib/stat.py:6: The stat.py module has been superseded by a C implementation in
I don't think that's the right way to do it.
If you want to keep stat.py, you should have it import from a C-coded _stat
module, as in other dual-implementation modules.

http://bugs.python.org/review/11016/diff/8445/Lib/test/test_stat.py
File Lib/test/test_stat.py (right):

http://bugs.python.org/review/11016/diff/8445/Lib/test/test_stat.py#newcode7
Lib/test/test_stat.py:7: def getstatpy():
This is horrible.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+