Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95122)

#11001: Various obvious errors in cookies documentation

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 5 months ago by L.Plant.98
Modified:
4 months ago
Reviewers:
vadmium+py
CC:
gregory.p.smith, r.david.murray, docs_python.org, spookylukey, Petri Lehtinen, mariatta.wijaya+miss-islington_gmail.com, julia.iluyk_gmail.com
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/http.cookies.rst View 2 chunks +8 lines, -7 lines 2 comments Download

Messages

Total messages: 2
Martin Panter
http://bugs.python.org/review/11001/diff/1905/Doc/library/http.cookies.rst File Doc/library/http.cookies.rst (right): http://bugs.python.org/review/11001/diff/1905/Doc/library/http.cookies.rst#newcode45 Doc/library/http.cookies.rst:45: and :meth:`value_encode` to use encoding appropriate for values outside ...
4 months ago #1
Martin Panter
4 months ago #2
http://bugs.python.org/review/11001/diff/1905/Doc/library/http.cookies.rst
File Doc/library/http.cookies.rst (right):

http://bugs.python.org/review/11001/diff/1905/Doc/library/http.cookies.rst#ne...
Doc/library/http.cookies.rst:45: and :meth:`value_encode` to use encoding
appropriate for values outside
On 2019/04/25 06:19:33, Martin Panter wrote:

> Suggest clarify what you mean by “appropriate”. The encoding is not
appropriate
> if you want to satisfy the Netscape or RFC 6265 specifications for cookies.
See
> <https://bugs.python.org/issue19670>.

[Pasting a reply from Luke, who had trouble posting it]

Given the comments in that ticket, it could read:

  This class derives from :class:`BaseCookie` and overrides :meth:`value_decode`
  and :meth:`value_encode` to use RFC 2109 quoted-string escaping for values
  outside the alphanumeric set.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+