Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(25270)

#10968: threading.Timer should be a class so that it can be derived

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by gu0sur20
Modified:
8 years ago
Reviewers:
ezio.melotti
CC:
gvanrossum, collinw_gmail.com, amaury.forgeotdarc, sasha, AntoinePitrou, haypo, eric.smith, giampaolo.rodola, eric.araujo, r.david.murray, gu0sur20_gmail.com, kleptog_gmail.com, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/multiprocessing.rst View 1 chunk +1 line, -1 line 0 comments Download
Doc/library/threading.rst View 16 chunks +85 lines, -100 lines 1 comment Download

Messages

Total messages: 1
ezio.melotti
8 years ago #1
http://bugs.python.org/review/10968/diff/3107/9637
File Doc/library/threading.rst (right):

http://bugs.python.org/review/10968/diff/3107/9637#newcode215
Doc/library/threading.rst:215: ``Thread`` used to be a factory function rather
than the class itself.
Something about this sentence sounds wrong to me.
IIUC in 3.2 Thread was a factory and _Thread was the real class, so saying "the
class itself" should be wrong because "itself" here refers to Thread (i.e. the
function) rather than _Thread (the class).  Using "a class" instead of "the
class itself" might be enough.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7+