Author jhylton
Recipients amaury.forgeotdarc, benjamin.peterson, cmcqueen1975, gvanrossum, jhylton, pje, rhettinger, terry.reedy
Date 2010-02-23.20:41:28
SpamBayes Score 4.03814e-07
Marked as misclassified No
Message-id <e8bf7a531002231241p7f4cbe4bj10328e40f49b9f75@mail.gmail.com>
In-reply-to <ca471dc21002230638s7b58400j3d30ff578c7fa478@mail.gmail.com>
Content
The patch looks pretty good.

I'd factor out the common error-checking code (common between
LOAD_DEREF and DELETE_DEREF) into a helper function.

It would also be good to add some test cases.

Jeremy

On Tue, Feb 23, 2010 at 9:38 AM, Guido van Rossum
<report@bugs.python.org> wrote:
>
> Guido van Rossum <guido@python.org> added the comment:
>
> I don't think so. It's very marginal.
>
> --Guido (on Android)
>
> On Feb 23, 2010 8:52 AM, "Amaury Forgeot d&apos;Arc" <report@bugs.python.org>
> wrote:
>
> Amaury Forgeot d'Arc <amauryfa@gmail.com> added the comment:
>
> The above patch adds a new opcode (DELETE_DEREF), does the Moratorium apply
> here?
>
> ----------
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python...
>
> ----------
> Added file: http://bugs.python.org/file16341/unnamed
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <http://bugs.python.org/issue4617>
> _______________________________________
History
Date User Action Args
2010-02-23 20:41:29jhyltonsetrecipients: + jhylton, gvanrossum, rhettinger, terry.reedy, pje, amaury.forgeotdarc, benjamin.peterson, cmcqueen1975
2010-02-23 20:41:28jhyltonlinkissue4617 messages
2010-02-23 20:41:28jhyltoncreate