Author Alexander.Belopolsky
Recipients Alexander.Belopolsky, aht, amaury.forgeotdarc, djc, hodgestar, pr0gg3d, zooko
Date 2010-02-23.17:28:45
SpamBayes Score 3.53067e-06
Marked as misclassified No
Message-id <1266946126.77.0.480550531229.issue6280@psf.upfronthosting.co.za>
In-reply-to
Content
The patch (I reviewed timemodule-gmtime-trunk.diff) looks mostly correct.  One problem that I see is that it will likely produce compiler warnings on the systems without timegm and mktime.  The warnings will be due to unused static function time_timegm and use of uninitialized variable tt.  I suggest that you wrap time_timegm in appropriate #ifdefs.

I trust that you tested that it works, but

#ifdef HAVE_TIMEGM || (defined(HAVE_MKTIME) && defined(HAVE_WORKING_TZSET))

looks like a non-standard construct to me.  I would do

#if defined(HAVE_TIMEGM) || (defined(HAVE_MKTIME) && defined(HAVE_WORKING_TZSET))

instead.

Finally, tests and documentation are needed.
History
Date User Action Args
2010-02-23 17:28:46Alexander.Belopolskysetrecipients: + Alexander.Belopolsky, zooko, amaury.forgeotdarc, djc, hodgestar, pr0gg3d, aht
2010-02-23 17:28:46Alexander.Belopolskysetmessageid: <1266946126.77.0.480550531229.issue6280@psf.upfronthosting.co.za>
2010-02-23 17:28:45Alexander.Belopolskylinkissue6280 messages
2010-02-23 17:28:45Alexander.Belopolskycreate