Author Alexander.Belopolsky
Recipients Alexander.Belopolsky, Neil Muller, andersjm, belopolsky, davidfraser, hodgestar, tebeka, vstinner, werneck
Date 2010-02-18.22:58:01
SpamBayes Score 0.000194237
Marked as misclassified No
Message-id <1266533884.51.0.696693787224.issue2736@psf.upfronthosting.co.za>
In-reply-to
Content
Victor,

As you explain in your own documentation, the proposed method is equivalent to ``(time.mktime(self.timetuple()), self.microsecond)``, so all it does is replacing a less than a one-liner.  Moreover, I am not sure time.mktime(self.timetuple()) is something that people would want to do with a TZ-aware datetime.  If the tzinfo of the datetime object does not match the system TZ used by mktime, the result will be quite misleading.

On the patch itself:

1. See my comment at Issue1726687 about the tm_wday == 1 typo.

2. I don't think time_t to long cast is safe on all platforms.
History
Date User Action Args
2010-02-18 22:58:05Alexander.Belopolskysetrecipients: + Alexander.Belopolsky, tebeka, davidfraser, belopolsky, andersjm, vstinner, werneck, hodgestar, Neil Muller
2010-02-18 22:58:04Alexander.Belopolskysetmessageid: <1266533884.51.0.696693787224.issue2736@psf.upfronthosting.co.za>
2010-02-18 22:58:02Alexander.Belopolskylinkissue2736 messages
2010-02-18 22:58:01Alexander.Belopolskycreate