Message99385
Hello
The feature seems useful to me and the patch straightforward.
I wonder why you used a global name for the max length (“_MAXCACHE”) instead of inlining the value where it is used. Does it feel more constanty? ;) I fear that the leading underscore won’t discourage users from touching it, so I’d suggest making it public or completely hidden. On second thought, you could argue that Python is a matter of consenting adults, and that leading underscore is okay.
Regards |
|
Date |
User |
Action |
Args |
2010-02-16 05:02:13 | eric.araujo | set | recipients:
+ eric.araujo, andrewclegg |
2010-02-16 05:02:12 | eric.araujo | set | messageid: <1266296532.89.0.195780253421.issue7846@psf.upfronthosting.co.za> |
2010-02-16 05:02:10 | eric.araujo | link | issue7846 messages |
2010-02-16 05:02:10 | eric.araujo | create | |
|