Author meador.inge
Recipients barry, brett.cannon, fdrake, mark.dickinson, meador.inge, ned.deily, ronaldoussoren, srid, zvezdan
Date 2010-02-07.21:02:04
SpamBayes Score 4.42235e-07
Marked as misclassified No
Message-id <4095897c1002071302p3e8124eenc6523bad600a4363@mail.gmail.com>
In-reply-to <1265573127.5.0.835385382898.issue6877@psf.upfronthosting.co.za>
Content
> That bit is not in the trunk, should it be forward ported to the trunk?

FWIW, I would really like to have it.

> The actual prototype on 10.5 and 10.6 is:
>
> char           **completion_matches(const char *, CPFunction *);
>
> Wouldn't it be better to change the prototype in readline.c to match?

I may have missed something, but the patch is actually *excluding* the
prototype on OS X, i.e. #if *not* defined.  Thus the 'const char*' prototype
that comes in with 'readline.h' is the one that will be used.

On the other hand, if you are proposing to make them 'match' just to avoid
the redefinition conflict, then this may break on other systems where 'char
*' is used.

Regards,

-- Meador
Files
File name Uploaded
unnamed meador.inge, 2010-02-07.21:02:03
History
Date User Action Args
2010-02-07 21:02:07meador.ingesetrecipients: + meador.inge, fdrake, barry, brett.cannon, ronaldoussoren, mark.dickinson, ned.deily, zvezdan, srid
2010-02-07 21:02:04meador.ingelinkissue6877 messages
2010-02-07 21:02:04meador.ingecreate