Author ronaldoussoren
Recipients barry, brett.cannon, fdrake, mark.dickinson, meador.inge, ned.deily, ronaldoussoren, srid, zvezdan
Date 2010-02-07.20:05:25
SpamBayes Score 2.06413e-05
Marked as misclassified No
Message-id <1265573127.5.0.835385382898.issue6877@psf.upfronthosting.co.za>
In-reply-to
Content
I have a question about this bit of the patch:

@@ -38,10 +38,31 @@
 #if defined(_RL_FUNCTION_TYPEDEF)
 extern char **completion_matches(char *, rl_compentry_func_t *);
 #else
+#if !defined(__APPLE__)
 extern char **completion_matches(char *, CPFunction *);
 #endif
 #endif
+#endif

That bit is not in the trunk, should it be forward ported to the trunk?

The actual prototype on 10.5 and 10.6 is:

char           **completion_matches(const char *, CPFunction *);

Wouldn't it be better to change the prototype in readline.c to match?

As that's not a critical change I've committed the fix1 patch as is in r78096.
History
Date User Action Args
2010-02-07 20:05:27ronaldoussorensetrecipients: + ronaldoussoren, fdrake, barry, brett.cannon, mark.dickinson, ned.deily, zvezdan, srid, meador.inge
2010-02-07 20:05:27ronaldoussorensetmessageid: <1265573127.5.0.835385382898.issue6877@psf.upfronthosting.co.za>
2010-02-07 20:05:26ronaldoussorenlinkissue6877 messages
2010-02-07 20:05:25ronaldoussorencreate