Message 98562 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	amaury.forgeotdarc, jnoller, nirai, pitrou, vstinner
Date	2010-01-30.13:06:50
SpamBayes Score	1.830483e-07
Marked as misclassified	No
Message-id	<1264856812.31.0.858316103101.issue7544@psf.upfronthosting.co.za>
In-reply-to

Content
I didn't test the patch but some comments: - PyThreadState_Prealloc and PyThreadState_Init should probably be prefixed with an underscore, because there's no use for them outside of the interpreter - _PyThreadState_New should be static. Besides, static functions usually don't get the "Py" in their name and are all lowercased, so something like "new_threadstate" - the last change ("Py_InitializeEx() calls _PyGILState_Init() before initsite()") should be part of a separate patch (and issue?)

I didn't test the patch but some comments:
- PyThreadState_Prealloc and PyThreadState_Init should probably be prefixed with an underscore, because there's no use for them outside of the interpreter
- _PyThreadState_New should be static. Besides, static functions usually don't get the "Py" in their name and are all lowercased, so something like "new_threadstate"
- the last change ("Py_InitializeEx() calls _PyGILState_Init() before initsite()") should be part of a separate patch (and issue?)

History
Date	User	Action	Args
2010-01-30 13:06:53	pitrou	set	recipients: + pitrou, amaury.forgeotdarc, vstinner, jnoller, nirai
2010-01-30 13:06:52	pitrou	set	messageid: <1264856812.31.0.858316103101.issue7544@psf.upfronthosting.co.za>
2010-01-30 13:06:50	pitrou	link	issue7544 messages
2010-01-30 13:06:50	pitrou	create