Message98494
Here's mine about issue7092_check_warnings_v3.diff:
1) test_callable should keep testing callable() and the warnings should be caught;
2) in test_bsddb3 the problems should be correct in the module if possible and worth it (the module is deprecated);
3) next to the several '# Silence py3k warnings' it would be nice to have a note about what warning you are exactly silencing;
4) def test_deprecated_builtin_map -> test_deprecated_builtin_map_with_None, otherwise it seems that map is deprecated;
5) in test[_deep]_copy I'm not entirely sure that the tests are equivalent using in (and if they are you should use assertIn);
6) in test_socket I would keep callable, also shouldn't the raise in the next line raise a warning as well?;
7) the self.assertEqual(`u2`, `d2`) in test_userdict could just use repr() instead;
8) a few tests in test_weakref should use assert[Not]In instead of assertTrue(x [not] in y). |
|
Date |
User |
Action |
Args |
2010-01-29 01:28:53 | ezio.melotti | set | recipients:
+ ezio.melotti, barry, rhettinger, exarkun, amaury.forgeotdarc, pitrou, benjamin.peterson, eric.araujo, brian.curtin, flox, esam |
2010-01-29 01:28:52 | ezio.melotti | set | messageid: <1264728532.72.0.385709856804.issue7092@psf.upfronthosting.co.za> |
2010-01-29 01:28:51 | ezio.melotti | link | issue7092 messages |
2010-01-29 01:28:50 | ezio.melotti | create | |
|