This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ezio.melotti
Recipients amaury.forgeotdarc, barry, benjamin.peterson, brian.curtin, eric.araujo, esam, exarkun, ezio.melotti, flox, pitrou, rhettinger
Date 2010-01-29.01:28:49
SpamBayes Score 3.505659e-07
Marked as misclassified No
Message-id <1264728532.72.0.385709856804.issue7092@psf.upfronthosting.co.za>
In-reply-to
Content
Here's mine about issue7092_check_warnings_v3.diff:

1) test_callable should keep testing callable() and the warnings should be caught;
2) in test_bsddb3 the problems should be correct in the module if possible and worth it (the module is deprecated);
3) next to the several '# Silence py3k warnings' it would be nice to have a note about what warning you are exactly silencing;
4) def test_deprecated_builtin_map -> test_deprecated_builtin_map_with_None, otherwise it seems that map is deprecated;
5) in test[_deep]_copy I'm not entirely sure that the tests are equivalent using in (and if they are you should use assertIn);
6) in test_socket I would keep callable, also shouldn't the raise in the next line raise a warning as well?;
7)  the self.assertEqual(`u2`, `d2`) in test_userdict could just use repr() instead;
8) a few tests in test_weakref should use assert[Not]In instead of assertTrue(x [not] in y).
History
Date User Action Args
2010-01-29 01:28:53ezio.melottisetrecipients: + ezio.melotti, barry, rhettinger, exarkun, amaury.forgeotdarc, pitrou, benjamin.peterson, eric.araujo, brian.curtin, flox, esam
2010-01-29 01:28:52ezio.melottisetmessageid: <1264728532.72.0.385709856804.issue7092@psf.upfronthosting.co.za>
2010-01-29 01:28:51ezio.melottilinkissue7092 messages
2010-01-29 01:28:50ezio.melotticreate