This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author r.david.murray
Recipients brett.cannon, pitrou, r.david.murray, roysmith, thomas.holmes
Date 2010-01-26.16:17:17
SpamBayes Score 1.532e-12
Marked as misclassified No
Message-id <1264522642.46.0.460523190788.issue7325@psf.upfronthosting.co.za>
In-reply-to
Content
First of all, thanks for working on this.  Now for some feedback :)

It is most helpful if you provide patches against trunk (which is 2.7 alpha right now).  We then forward port them to py3k.  (This will change after the release of 2.7, when py3k will become trunk.)

Isn't the assert you added to nameCheck redundant?  It seems to me it would be better just to remove the abspath call on ndir from the existing assert.

I haven't applied and tested the patch, but the other changes to the tests look odd to me.  Why are you obtaining the abspath of the current directory?  And why do those tests need to be changed at all?

Your additional test case looks like it might be some exploration code you forgot to delete before generating the patch, maybe those other changes are as well?
History
Date User Action Args
2010-01-26 16:17:22r.david.murraysetrecipients: + r.david.murray, brett.cannon, roysmith, pitrou, thomas.holmes
2010-01-26 16:17:22r.david.murraysetmessageid: <1264522642.46.0.460523190788.issue7325@psf.upfronthosting.co.za>
2010-01-26 16:17:18r.david.murraylinkissue7325 messages
2010-01-26 16:17:17r.david.murraycreate