Message 98043 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	r.david.murray
Recipients	barry, r.david.murray, ynkdir
Date	2010-01-19.02:11:59
SpamBayes Score	6.868113e-06
Marked as misclassified	No
Message-id	<1263867122.32.0.871631813698.issue7472@psf.upfronthosting.co.za>
In-reply-to

Content
Hmm. I suspect that that typo is fortunate rather than the source of a bug. As far as I can see, if a message contains valid iso-2022 characters, it will always encode to ASCII successfully and therefore be given a content-transfer-encoding of 7bit. If on the other hand it contains 8 bit characters, it should be marked as 8bit, even if it claims to be iso-2022. (Well, actually it should throw an error, but that's a different bug.) In other words, I think the correct thing to do is to delete that if test. Do you have a case where the code produces incorrect behavior that your patch turns into correct behavior?

Hmm.  I suspect that that typo is fortunate rather than the source of a bug.  As far as I can see, if a message contains valid iso-2022 characters, it will always encode to ASCII successfully and therefore be given a content-transfer-encoding of 7bit.  If on the other hand it contains 8 bit characters, it should be marked as 8bit, even if it claims to be iso-2022.  (Well, actually it should throw an error, but that's a different bug.)

In other words, I think the correct thing to do is to delete that if test.

Do you have a case where the code produces incorrect behavior that your patch turns into correct behavior?

History
Date	User	Action	Args
2010-01-19 02:12:02	r.david.murray	set	recipients: + r.david.murray, barry, ynkdir
2010-01-19 02:12:02	r.david.murray	set	messageid: <1263867122.32.0.871631813698.issue7472@psf.upfronthosting.co.za>
2010-01-19 02:12:00	r.david.murray	link	issue7472 messages
2010-01-19 02:11:59	r.david.murray	create