Author loewis
Recipients amaury.forgeotdarc, asvetlov, brian.curtin, eric.smith, giampaolo.rodola, jafo, jaraco, lemburg, loewis, nnorwitz, r.david.murray, ssbarnea, swarren
Date 2010-01-18.20:28:30
SpamBayes Score 4.63771e-07
Marked as misclassified No
Message-id <4B54C46C.6050701@v.loewis.de>
In-reply-to <1263822997.54.0.935658682658.issue1578269@psf.upfronthosting.co.za>
Content
> Given that there is a specific permission that can be assigned to the
> buildslave user, it seems appropriate that the tests that attempt to
> create symlinks should fail if the user does not have that
> permission.

No, the test should *not* fail. A failing test means "the test has
completed, and the outcome was not expected, due to a bug somewhere
(the operating system, Python, or the test case proper)". This is not
the case if the link cannot be created - the resulting behavior is
exactly the correct, and expected one (under the circumstances).

> Martin, do you still prefer something that wraps tests that call
> symlink and only executes those tests if the current user context has
> that permission?

Most definitely. That's what the notion of a "skipped" test is for
(as opposed to a "failed" one).
History
Date User Action Args
2010-01-18 20:28:33loewissetrecipients: + loewis, lemburg, nnorwitz, jafo, amaury.forgeotdarc, jaraco, eric.smith, giampaolo.rodola, swarren, r.david.murray, ssbarnea, brian.curtin, asvetlov
2010-01-18 20:28:31loewislinkissue1578269 messages
2010-01-18 20:28:30loewiscreate