Author pakal
Recipients pakal, pitrou
Date 2010-01-16.12:09:55
SpamBayes Score 2.96587e-05
Marked as misclassified No
Message-id <1263643799.71.0.653830079599.issue6939@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the detailed feedback.

According to what you said (and to details found in python docs), the current _fileio.truncate is actually quite buggy -> no reference counting ops were done on posobj, even though it's sometimes retrieved from _portable_seek, and returned or not depending on rare error cases (SetEndOfFile failing etc.).

Here is a patch fixing all that for python2.6, I've tested it manually in debug mode, and against memoryio/io/fileio tests ; hope it will be OK.

As soon as this one is certified, I'll prepare a patch for python2.7
History
Date User Action Args
2010-01-16 12:09:59pakalsetrecipients: + pakal, pitrou
2010-01-16 12:09:59pakalsetmessageid: <1263643799.71.0.653830079599.issue6939@psf.upfronthosting.co.za>
2010-01-16 12:09:57pakallinkissue6939 messages
2010-01-16 12:09:57pakalcreate