Author pitrou
Recipients pakal, pitrou
Date 2010-01-15.19:17:09
SpamBayes Score 1.27478e-08
Marked as misclassified No
Message-id <1263583033.24.0.985262750884.issue6939@psf.upfronthosting.co.za>
In-reply-to
Content
Looking at the patches:
- if you want to remove code, please remove it; don't comment it out
- please don't use C++-style comments (it will break on some compilers, produce warnings on others)
- code lines should generally not be wider than 80 chars (although this is not really a hard rule)
- I don't understand the purpose of "self.seek(0, os.SEEK_CUR)"; shouldn't it be a no-op? If not, please add a comment to explain why.
- you are not decrefinf objects properly when you are done with them (posobj, oldposobj), which will certainly produce memory leaks
- some tests seem to be missing from the 2.7 patch, compared to the 2.6 one
- if you want to test BytesIO and StringIO, tests can be added to Lib/test/test_memoryio.py
History
Date User Action Args
2010-01-15 19:17:13pitrousetrecipients: + pitrou, pakal
2010-01-15 19:17:13pitrousetmessageid: <1263583033.24.0.985262750884.issue6939@psf.upfronthosting.co.za>
2010-01-15 19:17:09pitroulinkissue6939 messages
2010-01-15 19:17:09pitroucreate