Message 97772 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	flox, pitrou, theller
Date	2010-01-14.16:01:54
SpamBayes Score	0.011340124
Marked as misclassified	No
Message-id	<1263484916.38.0.3894316782.issue7703@psf.upfronthosting.co.za>
In-reply-to

Content
Please be careful with the coding style. Stuff like: + if (_PyString_Resize(&rv, 2*out_len) < 0) \ + { Py_DECREF(rv); PyBuffer_Release(&pin); return NULL; } \ should be spread out on several lines. Otherwise, the binascii patch looks good.

Please be careful with the coding style. Stuff like:

+			  if (_PyString_Resize(&rv, 2*out_len) < 0) \
+			    { Py_DECREF(rv); PyBuffer_Release(&pin); return NULL; } \

should be spread out on several lines.
Otherwise, the binascii patch looks good.

History
Date	User	Action	Args
2010-01-14 16:01:56	pitrou	set	recipients: + pitrou, theller, flox
2010-01-14 16:01:56	pitrou	set	messageid: <1263484916.38.0.3894316782.issue7703@psf.upfronthosting.co.za>
2010-01-14 16:01:54	pitrou	link	issue7703 messages
2010-01-14 16:01:54	pitrou	create