Author pitrou
Recipients lucifer, nirai, pitrou
Date 2010-01-12.21:34:33
SpamBayes Score 2.62205e-05
Marked as misclassified No
Message-id <1263332075.82.0.258603714937.issue7610@psf.upfronthosting.co.za>
In-reply-to
Content
Some comments:
* you should probably write `n = sys.maxsize` instead of `n = 1 << 31 - 1`
* ZipExtFile.read() should support `n=None` as a synonym to `n=-1` (read everything)
* `bytes` as a variable name isn't very good since it's the built-in name for bytestrings in py3k
* in ZipExtFile.read(), it seems you have removed the adjustment for encrypted files (see `adjust read size for encrypted files since the first 12 bytes [etc.]`)
* is there a situation where the decompressor might return less bytes than expected? (after all compression doesn't /always/ compress, in unfavourable chunks of data it might actually expand things a bit)
History
Date User Action Args
2010-01-12 21:34:36pitrousetrecipients: + pitrou, nirai, lucifer
2010-01-12 21:34:35pitrousetmessageid: <1263332075.82.0.258603714937.issue7610@psf.upfronthosting.co.za>
2010-01-12 21:34:33pitroulinkissue7610 messages
2010-01-12 21:34:33pitroucreate