Author lemburg
Recipients eric.smith, ezio.melotti, flox, lemburg, pitrou
Date 2010-01-04.15:55:28
SpamBayes Score 8.18054e-05
Marked as misclassified No
Message-id <1262620530.61.0.165974076432.issue7622@psf.upfronthosting.co.za>
In-reply-to
Content
Florent Xicluna wrote:
> > 
> > Florent Xicluna <laxyf@yahoo.fr> added the comment:
> > 
>> >> * function declarations should not put parameters on new lines:
>> >>
>> >>  +stringlib_splitlines(
>> >>  +    PyObject* str_obj, const STRINGLIB_CHAR* str, Py_ssize_t str_len,
>> >>  +    int keepends
>> >>  +    )
>> >>  +{
> > 
> > I copied the style of "stringlib/partition.h" for this part.
> > Should I update style of "partition.h" too?

I'd prefer if you change the coding style to what we use elsewhere
in Python C code.

See http://www.python.org/dev/peps/pep-0007/ for more C coding
style suggestions.
History
Date User Action Args
2010-01-04 15:55:30lemburgsetrecipients: + lemburg, pitrou, eric.smith, ezio.melotti, flox
2010-01-04 15:55:30lemburgsetmessageid: <1262620530.61.0.165974076432.issue7622@psf.upfronthosting.co.za>
2010-01-04 15:55:29lemburglinkissue7622 messages
2010-01-04 15:55:29lemburgcreate