This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author lemburg
Recipients ebfe, gregory.p.smith, hagen, kmtracey, lemburg, pitrou, rpetrov, vstinner
Date 2009-12-29.13:37:13
SpamBayes Score 1.8785329e-06
Marked as misclassified No
Message-id <4B3A0608.3050203@egenix.com>
In-reply-to <1261966434.75.0.443539224774.issue3745@psf.upfronthosting.co.za>
Content
Gregory P. Smith wrote:
> 
> Gregory P. Smith <greg@krypto.org> added the comment:
> 
> lemburg - see which issue #?

Sorry, the message got truncated for some reason.

I was referring to http://bugs.python.org/issue3745

This was discussed on python-dev: http://mail.python.org/pipermail/python-dev/2009-December/094593.html

> Anyways perhaps the right thing to do instead of trunk r65961 would have 
> been to change the s# to an s*.

That would have worked as well.

> Undoing it will be more painful now as several changes have gone in since 
> that require undoing and possibly redoing differently.

Using s* should pretty much avoid the need to use GET_BUFFER_VIEW_OR_ERROUT(),
so if you want to keep the other changes, removing the use of the
macro should be fairly straight-forward, unless I'm missing something.
History
Date User Action Args
2009-12-29 13:37:15lemburgsetrecipients: + lemburg, gregory.p.smith, pitrou, vstinner, kmtracey, hagen, rpetrov, ebfe
2009-12-29 13:37:13lemburglinkissue3745 messages
2009-12-29 13:37:13lemburgcreate