This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author ezio.melotti
Recipients ezio.melotti, ferringb
Date 2009-12-29.08:39:18
SpamBayes Score 8.8363015e-07
Marked as misclassified No
Message-id <1262075961.51.0.424808488228.issue7594@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for the patch.

Three minor things:
1) the source contains non-ASCII chars and an encoding declaration at
the beginning of the file. PEP8 says that "using \x, \u or \U escapes is
the preferred way to include non-ASCII data in string literals", so I
would use \x escapes and remove the encoding declaration;
2) the class "stream_source" should be named "StreamSource" unless there
are compatibility or consistency issues;
3) patches should be done against trunk first (your patch applies fine
on trunk too and the tests pass), they will then be ported to py3k.
History
Date User Action Args
2009-12-29 08:39:21ezio.melottisetrecipients: + ezio.melotti, ferringb
2009-12-29 08:39:21ezio.melottisetmessageid: <1262075961.51.0.424808488228.issue7594@psf.upfronthosting.co.za>
2009-12-29 08:39:19ezio.melottilinkissue7594 messages
2009-12-29 08:39:18ezio.melotticreate