Author mark.dickinson
Recipients mark.dickinson, rpetrov
Date 2009-12-17.08:53:34
SpamBayes Score 1.63647e-13
Marked as misclassified No
Message-id <1261040017.28.0.0309314211423.issue7518@psf.upfronthosting.co.za>
In-reply-to
Content
So the configure test for tanh(-0.0) is purely informational:  it doesn't 
affect the behaviour of the built Python in any way.  I agree that the 
test is imperfect, in that if atan2 is also non-conformant on the given 
platform then the sign issue with tanh may go undetected, but all that 
happens in that case is that we get a bogus 'preserves sign of -0 ... yes' 
message in the configure output.

The wrapper for atan2 in Modules/mathmodules.c is a separate issue; it 
should ensure that we get the right behaviour for atan2 on all platforms,
including msvc 7.0.  I can't immediately see any reason why it wouldn't be 
working as intended.

> I don't think that python cmath tests will pass with MSVC before
8.0.

Which test(s) do you think will fail?

> May be is good to add depends=['_math.h'], for modules in setup.py.

Good point---thanks!  Done in r76865 (trunk), r76867 (py3k).
History
Date User Action Args
2009-12-17 08:53:37mark.dickinsonsetrecipients: + mark.dickinson, rpetrov
2009-12-17 08:53:37mark.dickinsonsetmessageid: <1261040017.28.0.0309314211423.issue7518@psf.upfronthosting.co.za>
2009-12-17 08:53:35mark.dickinsonlinkissue7518 messages
2009-12-17 08:53:34mark.dickinsoncreate