Message95883
I think you need to put an assert before the line with bufflen-x, since
that's the calculation you're trying to ensure doesn't underflow. And I
guess that technically you should inspect the result of PyOS_snprintf
for an error, but given that we know the buffer sizes it's not so important.
Other than that, looks good. Sorry for the piecemeal patch review. |
|
Date |
User |
Action |
Args |
2009-12-01 22:43:56 | eric.smith | set | recipients:
+ eric.smith, exarkun, amaury.forgeotdarc |
2009-12-01 22:43:56 | eric.smith | set | messageid: <1259707436.8.0.327981816934.issue7413@psf.upfronthosting.co.za> |
2009-12-01 22:43:55 | eric.smith | link | issue7413 messages |
2009-12-01 22:43:54 | eric.smith | create | |
|