This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.smith
Recipients amaury.forgeotdarc, eric.smith, exarkun
Date 2009-12-01.22:43:54
SpamBayes Score 5.7371463e-09
Marked as misclassified No
Message-id <1259707436.8.0.327981816934.issue7413@psf.upfronthosting.co.za>
In-reply-to
Content
I think you need to put an assert before the line with bufflen-x, since
that's the calculation you're trying to ensure doesn't underflow. And I
guess that technically you should inspect the result of PyOS_snprintf
for an error, but given that we know the buffer sizes it's not so important.

Other than that, looks good. Sorry for the piecemeal patch review.
History
Date User Action Args
2009-12-01 22:43:56eric.smithsetrecipients: + eric.smith, exarkun, amaury.forgeotdarc
2009-12-01 22:43:56eric.smithsetmessageid: <1259707436.8.0.327981816934.issue7413@psf.upfronthosting.co.za>
2009-12-01 22:43:55eric.smithlinkissue7413 messages
2009-12-01 22:43:54eric.smithcreate