This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author eric.smith
Recipients amaury.forgeotdarc, eric.smith, exarkun
Date 2009-12-01.10:54:58
SpamBayes Score 8.86411e-08
Marked as misclassified No
Message-id <1259664902.19.0.816425633343.issue7413@psf.upfronthosting.co.za>
In-reply-to
Content
The patch looks okay to me, and works on 2.7. Although it's slightly out
of date with respect to line numbers, it still applies cleanly.

My trivial suggestions are that I'd replace:
x += PyOS_snprintf(buffer + 8, bufflen - 8, ".%06d", us);
with
x += PyOS_snprintf(buffer + x, bufflen - x, ".%06d", us);
in the extremely unlikely event that the time format string ever
changes. I'd probably also throw in an assert(bufflen >= x).

But these 2 points are nits.
History
Date User Action Args
2009-12-01 10:55:02eric.smithsetrecipients: + eric.smith, exarkun, amaury.forgeotdarc
2009-12-01 10:55:02eric.smithsetmessageid: <1259664902.19.0.816425633343.issue7413@psf.upfronthosting.co.za>
2009-12-01 10:54:59eric.smithlinkissue7413 messages
2009-12-01 10:54:58eric.smithcreate