Message95854
The patch looks okay to me, and works on 2.7. Although it's slightly out
of date with respect to line numbers, it still applies cleanly.
My trivial suggestions are that I'd replace:
x += PyOS_snprintf(buffer + 8, bufflen - 8, ".%06d", us);
with
x += PyOS_snprintf(buffer + x, bufflen - x, ".%06d", us);
in the extremely unlikely event that the time format string ever
changes. I'd probably also throw in an assert(bufflen >= x).
But these 2 points are nits. |
|
Date |
User |
Action |
Args |
2009-12-01 10:55:02 | eric.smith | set | recipients:
+ eric.smith, exarkun, amaury.forgeotdarc |
2009-12-01 10:55:02 | eric.smith | set | messageid: <1259664902.19.0.816425633343.issue7413@psf.upfronthosting.co.za> |
2009-12-01 10:54:59 | eric.smith | link | issue7413 messages |
2009-12-01 10:54:58 | eric.smith | create | |
|