Author eric.smith
Recipients eric.smith, mark.dickinson
Date 2009-11-29.14:15:03
SpamBayes Score 1.0721e-08
Marked as misclassified No
Message-id <1259504105.93.0.741535720669.issue3382@psf.upfronthosting.co.za>
In-reply-to
Content
Thanks for looking at this, Mark.

Your patch looks okay to me, but Objects/stringlib/formatter.h still has
some 'F' -> 'f' logic in it, although it turns out that it's wrong:

#if PY_VERSION_HEX < 0x0301000
    /* 'F' is the same as 'f', per the PEP */
    /* This is no longer the case in 3.x */
    if (type == 'F')
        type = 'f';
#endif

Note that it's missing a zero on the end, so this code is never (and I
guess never was) executed. I'll remove it and add a test.

It also looks like complex is still mapping 'F' to 'f'. I'll fix that,
too, and add a test for it.

Thanks again.
History
Date User Action Args
2009-11-29 14:15:06eric.smithsetrecipients: + eric.smith, mark.dickinson
2009-11-29 14:15:05eric.smithsetmessageid: <1259504105.93.0.741535720669.issue3382@psf.upfronthosting.co.za>
2009-11-29 14:15:04eric.smithlinkissue3382 messages
2009-11-29 14:15:03eric.smithcreate