Message95704
Some quick comments on your patch (not an in-depth review):
- you should add some tests for the problem you're trying to solve
- using __del__ when you have a weakref is counter-productive; use the
weakref's optional callback instead
- if you remove arbitrary elements from it, _handlerList should probably
be a set rather a list (but it's more of an optimization concern)
- `for h in [wr() for wr in handlerList if wr() is not None]` isn't a
pretty notation; just put the `if` inside the `for` instead |
|
Date |
User |
Action |
Args |
2009-11-24 22:46:53 | pitrou | set | recipients:
+ pitrou, vinay.sajip, amaury.forgeotdarc, OG7, jnoller, flox |
2009-11-24 22:46:53 | pitrou | set | messageid: <1259102813.4.0.786911729588.issue6615@psf.upfronthosting.co.za> |
2009-11-24 22:46:52 | pitrou | link | issue6615 messages |
2009-11-24 22:46:51 | pitrou | create | |
|