Author pitrou
Recipients OG7, amaury.forgeotdarc, flox, jnoller, pitrou, vinay.sajip
Date 2009-11-24.22:46:51
SpamBayes Score 0.000127281
Marked as misclassified No
Message-id <1259102813.4.0.786911729588.issue6615@psf.upfronthosting.co.za>
In-reply-to
Content
Some quick comments on your patch (not an in-depth review):
- you should add some tests for the problem you're trying to solve
- using __del__ when you have a weakref is counter-productive; use the
weakref's optional callback instead
- if you remove arbitrary elements from it, _handlerList should probably
be a set rather a list (but it's more of an optimization concern)
- `for h in [wr() for wr in handlerList if wr() is not None]` isn't a
pretty notation; just put the `if` inside the `for` instead
History
Date User Action Args
2009-11-24 22:46:53pitrousetrecipients: + pitrou, vinay.sajip, amaury.forgeotdarc, OG7, jnoller, flox
2009-11-24 22:46:53pitrousetmessageid: <1259102813.4.0.786911729588.issue6615@psf.upfronthosting.co.za>
2009-11-24 22:46:52pitroulinkissue6615 messages
2009-11-24 22:46:51pitroucreate